From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164AbaBLLQi (ORCPT ); Wed, 12 Feb 2014 06:16:38 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38037 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbaBLLQg (ORCPT ); Wed, 12 Feb 2014 06:16:36 -0500 Date: Wed, 12 Feb 2014 11:16:31 +0000 From: Mel Gorman To: Johannes Weiner Cc: Andrew Morton , Andi Kleen , Andrea Arcangeli , Bob Liu , Christoph Hellwig , Dave Chinner , Greg Thelen , Hugh Dickins , Jan Kara , KOSAKI Motohiro , Luigi Semenzato , Metin Doslu , Michel Lespinasse , Minchan Kim , Ozgun Erdogan , Peter Zijlstra , Rik van Riel , Roman Gushchin , Ryan Mallon , Tejun Heo , Vlastimil Babka , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 05/10] mm: filemap: move radix tree hole searching here Message-ID: <20140212111631.GS6732@suse.de> References: <1391475222-1169-1-git-send-email-hannes@cmpxchg.org> <1391475222-1169-6-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1391475222-1169-6-git-send-email-hannes@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 03, 2014 at 07:53:37PM -0500, Johannes Weiner wrote: > The radix tree hole searching code is only used for page cache, for > example the readahead code trying to get a a picture of the area > surrounding a fault. > > It sufficed to rely on the radix tree definition of holes, which is > "empty tree slot". But this is about to change, though, as shadow > page descriptors will be stored in the page cache after the actual > pages get evicted from memory. > > Move the functions over to mm/filemap.c and make them native page > cache operations, where they can later be adapted to handle the new > definition of "page cache hole". > > Signed-off-by: Johannes Weiner > Reviewed-by: Rik van Riel > Reviewed-by: Minchan Kim Acked-by: Mel Gorman -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: [patch 05/10] mm: filemap: move radix tree hole searching here Date: Wed, 12 Feb 2014 11:16:31 +0000 Message-ID: <20140212111631.GS6732@suse.de> References: <1391475222-1169-1-git-send-email-hannes@cmpxchg.org> <1391475222-1169-6-git-send-email-hannes@cmpxchg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: Andrew Morton , Andi Kleen , Andrea Arcangeli , Bob Liu , Christoph Hellwig , Dave Chinner , Greg Thelen , Hugh Dickins , Jan Kara , KOSAKI Motohiro , Luigi Semenzato , Metin Doslu , Michel Lespinasse , Minchan Kim , Ozgun Erdogan , Peter Zijlstra , Rik van Riel , Roman Gushchin , Ryan Mallon , Tejun Heo , Vlastimil Babka , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Johannes Weiner Return-path: Content-Disposition: inline In-Reply-To: <1391475222-1169-6-git-send-email-hannes@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Feb 03, 2014 at 07:53:37PM -0500, Johannes Weiner wrote: > The radix tree hole searching code is only used for page cache, for > example the readahead code trying to get a a picture of the area > surrounding a fault. > > It sufficed to rely on the radix tree definition of holes, which is > "empty tree slot". But this is about to change, though, as shadow > page descriptors will be stored in the page cache after the actual > pages get evicted from memory. > > Move the functions over to mm/filemap.c and make them native page > cache operations, where they can later be adapted to handle the new > definition of "page cache hole". > > Signed-off-by: Johannes Weiner > Reviewed-by: Rik van Riel > Reviewed-by: Minchan Kim Acked-by: Mel Gorman -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org