From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58658)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WDrkh-0001E5-9j
	for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:34:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WDrkc-00017b-2E
	for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:34:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:15618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WDrkb-00017W-QF
	for qemu-devel@nongnu.org; Thu, 13 Feb 2014 03:34:29 -0500
Date: Thu, 13 Feb 2014 09:33:52 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140213083352.GD32343@dhcp-200-207.str.redhat.com>
References: <1392256297-21782-2-git-send-email-benoit.canet@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1392256297-21782-2-git-send-email-benoit.canet@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the
 block filter snapshots patchset.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: famz@redhat.com, Benoit Canet <benoit@irqsave.net>, jcody@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

Am 13.02.2014 um 02:51 hat Beno=EEt Canet geschrieben:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  block.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Should be [PATCH v3] in the subject line.

> diff --git a/block.c b/block.c
> index 70d7f35..d9553ba 100644
> --- a/block.c
> +++ b/block.c
> @@ -5419,11 +5419,7 @@ bool bdrv_is_first_non_filter(BlockDriverState *=
candidate)
>      QTAILQ_FOREACH(bs, &bdrv_states, device_list) {
>          bool perm;
> =20
> -        if (!bs->file) {
> -            continue;
> -        }
> -
> -        perm =3D bdrv_recurse_is_first_non_filter(bs->file, candidate)=
;
> +        perm =3D bdrv_recurse_is_first_non_filter(bs, candidate);
> =20
>          /* candidate is the first non filter */
>          if (perm) {

So we're back to my patch, just with different author? I thought you
said something was broken with it?

Kevin