All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: fche@redhat.com (Frank Ch. Eigler)
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rusty Russell <rusty@rustcorp.com.au>,
	David Howells <dhowells@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [RFC PATCH] Fix: module signature vs tracepoints: add new TAINT_UNSIGNED_MODULE
Date: Thu, 13 Feb 2014 10:44:29 -0500	[thread overview]
Message-ID: <20140213104429.478b56e8@gandalf.local.home> (raw)
In-Reply-To: <y0mlhxfnhx8.fsf@fche.csb>

On Thu, 13 Feb 2014 10:36:35 -0500
fche@redhat.com (Frank Ch. Eigler) wrote:

> 
> rostedt wrote:
> 
> > [...]
> > Oh! You are saying that if the kernel only *supports* signed modules,
> > and you load a module that is not signed, it will taint the kernel?
> 
> Yes: this is the default for several distros.
> 

Rusty, Ingo,

This looks like a bug to me, as it can affect even in-tree kernel
modules. If you have a kernel that supports signed modules, and you
modify a module, recompile it, apply it, since it is no longer signed,
then it sounds like we just tainted it. Worse yet, we just disabled any
tracepoints on that module, which means it is even harder to debug that
module (if that's the reason you recompiled it in the first place).

-- Steve

  reply	other threads:[~2014-02-13 15:44 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 23:23 [RFC PATCH] Fix: module signature vs tracepoints: add new TAINT_UNSIGNED_MODULE Mathieu Desnoyers
2014-02-11  7:27 ` Ingo Molnar
2014-02-12  4:45   ` Steven Rostedt
2014-02-12  5:51     ` Mathieu Desnoyers
2014-02-13  3:24     ` Rusty Russell
2014-02-13 21:11       ` Steven Rostedt
2014-02-13 21:24         ` Steven Rostedt
2014-02-14  3:32           ` Mathieu Desnoyers
2014-02-14  0:51         ` Rusty Russell
2014-02-16 23:58           ` Mathieu Desnoyers
2014-02-20 15:30           ` Steven Rostedt
2014-02-20 23:09             ` Rusty Russell
2014-02-21  4:09               ` Steven Rostedt
2014-02-21  8:10                 ` Johannes Berg
2014-02-26  2:51                   ` Rusty Russell
2014-02-26 12:55                     ` Mathieu Desnoyers
2014-02-13 15:10     ` Mathieu Desnoyers
2014-02-13 15:28       ` Steven Rostedt
2014-02-13 15:36         ` Frank Ch. Eigler
2014-02-13 15:44           ` Steven Rostedt [this message]
2014-02-13 21:42             ` Arend van Spriel
2014-02-13 15:41         ` Mathieu Desnoyers
2014-02-13 20:45           ` Steven Rostedt
2014-02-14  3:49             ` Mathieu Desnoyers
2014-02-24 15:54               ` Steven Rostedt
2014-02-24 16:55                 ` Mathieu Desnoyers
2014-02-24 17:39                   ` Steven Rostedt
2014-02-24 17:58                     ` Mathieu Desnoyers
2014-02-24 18:25                       ` Steven Rostedt
2014-02-26 19:55                       ` Steven Rostedt
2014-02-26  2:53                     ` Rusty Russell
2014-02-26 20:13                       ` Steven Rostedt
2014-02-24 18:32                 ` Mathieu Desnoyers
2014-02-24 19:10                   ` Steven Rostedt
2014-02-26 14:23                     ` Mathieu Desnoyers
2014-02-26 15:05                       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213104429.478b56e8@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=dhowells@redhat.com \
    --cc=fche@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.