From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 0/5] drm/i915: Full pipe rotation & rotation
 property name bikeshedding
Date: Thu, 13 Feb 2014 13:58:25 +0200
Message-ID: <20140213115825.GM3891@intel.com>
References: <1392239704-21776-1-git-send-email-ville.syrjala@linux.intel.com>
	<20140213112049.GQ14909@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20140213112049.GQ14909@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org, Sagar Kamble <sagar.a.kamble@intel.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Thu, Feb 13, 2014 at 11:20:49AM +0000, Chris Wilson wrote:
> On Wed, Feb 12, 2014 at 11:14:59PM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > After playing around Sagar's primary plane rotation a bit, I decided th=
at
> > extending that to full pipe rotation would be nice. Chris also seemed to
> > want that, but I'm not sure he does anymore :) But then I decided it's =
so
> > easy to implement that I can't leave it hanging. So here it is.
> =

> Ok, another fun issue is that I still have to reset all plane rotations
> when switching VT to X anyway, so having a property that chains the pipe
> on top of the plane rotations, just increases the amount of work I have
> to do. I may as well just set each plane rotation.

Yeah if we had atomic modeset + per-master state, and fbdev would be
like a master in this case, the correct state would get magically
blasted into the hardware on vt switch. One can dream, right? ;)

Even without that, I'd still vote for adding the full crtc rotation
property. It frees the client from having to adjust the coordinates
of individual planes when rotating the world. I guess for you that
would just mean resetting it to DRM_ROTATE_0 always.

-- =

Ville Syrj=E4l=E4
Intel OTC