From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbaBMMkL (ORCPT ); Thu, 13 Feb 2014 07:40:11 -0500 Received: from mail-we0-f177.google.com ([74.125.82.177]:40987 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753910AbaBMMkJ (ORCPT ); Thu, 13 Feb 2014 07:40:09 -0500 Date: Thu, 13 Feb 2014 12:40:02 +0000 From: Lee Jones To: Laszlo Papp Cc: Jean Delvare , LKML , lm-sensors@lm-sensors.org, Guenter Roeck Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Message-ID: <20140213124002.GA3403@lee--X1> References: <1392281438-31836-1-git-send-email-lpapp@kde.org> <20140213095817.GD32508@lee--X1> <20140213111530.2a2b4982@endymion.delvare> <20140213113313.GL32508@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > http://comments.gmane.org/gmane.linux.kernel/1645251 > > Step 2 did not happen. I did not get any review for my change. I > literally submitted that within a couple of hours after the request. > > Could you please tell me what was wrong with that change, and why I > did not get any respect not to "xargs rm -rf" my work in that area? I > believe I was ignored instead of improving the change, and someone > else tried to address the same thing. There was no argument in that > thread. It was a technical change. I personally do not feel happy > about it. Let's start again. Rebase your work on top of the HWMON tree on kernel.org and resubmit the entire set. If rebasing takes you more than 20 mins, you're probably doing it wrong. Ensure you submit the entire patchset with a nice cover letter and all the patches dangling (shallow threaded) from it. If you don't know how to do that look at `git send-email --help` and search for "thread", "annotate" and "compose". Keep submitting them to your own (and only your own) email address until it looks correct, _then_ submit to the MLs CC'ing all of the maintainers on all of the patches. Submission should look like this: [PATCH 0/x] Patch-set title \->[PATCH 1/x] mfd: Patch title |->[PATCH ./x] hwmon: Patch title |->[PATCH x/x] gpio/pinctrl: Patch title We'll give you constructive reviews and you'll ask questions (not arguments) and resubmit. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Thu, 13 Feb 2014 12:40:02 +0000 Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Message-Id: <20140213124002.GA3403@lee--X1> List-Id: References: <1392281438-31836-1-git-send-email-lpapp@kde.org> <20140213095817.GD32508@lee--X1> <20140213111530.2a2b4982@endymion.delvare> <20140213113313.GL32508@lee--X1> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laszlo Papp Cc: Jean Delvare , LKML , lm-sensors@lm-sensors.org, Guenter Roeck PiBodHRwOi8vY29tbWVudHMuZ21hbmUub3JnL2dtYW5lLmxpbnV4Lmtlcm5lbC8xNjQ1MjUxCj4g Cj4gU3RlcCAyIGRpZCBub3QgaGFwcGVuLiBJIGRpZCBub3QgZ2V0IGFueSByZXZpZXcgZm9yIG15 IGNoYW5nZS4gSQo+IGxpdGVyYWxseSBzdWJtaXR0ZWQgdGhhdCB3aXRoaW4gYSBjb3VwbGUgb2Yg aG91cnMgYWZ0ZXIgdGhlIHJlcXVlc3QuCj4gCj4gQ291bGQgeW91IHBsZWFzZSB0ZWxsIG1lIHdo YXQgd2FzIHdyb25nIHdpdGggdGhhdCBjaGFuZ2UsIGFuZCB3aHkgSQo+IGRpZCBub3QgZ2V0IGFu eSByZXNwZWN0IG5vdCB0byAieGFyZ3Mgcm0gLXJmIiBteSB3b3JrIGluIHRoYXQgYXJlYT8gSQo+ IGJlbGlldmUgSSB3YXMgaWdub3JlZCBpbnN0ZWFkIG9mIGltcHJvdmluZyB0aGUgY2hhbmdlLCBh bmQgc29tZW9uZQo+IGVsc2UgdHJpZWQgdG8gYWRkcmVzcyB0aGUgc2FtZSB0aGluZy4gVGhlcmUg d2FzIG5vIGFyZ3VtZW50IGluIHRoYXQKPiB0aHJlYWQuIEl0IHdhcyBhIHRlY2huaWNhbCBjaGFu Z2UuIEkgcGVyc29uYWxseSBkbyBub3QgZmVlbCBoYXBweQo+IGFib3V0IGl0LgoKTGV0J3Mgc3Rh cnQgYWdhaW4uCgpSZWJhc2UgeW91ciB3b3JrIG9uIHRvcCBvZiB0aGUgSFdNT04gdHJlZSBvbiBr ZXJuZWwub3JnIGFuZCByZXN1Ym1pdAp0aGUgZW50aXJlIHNldC4gSWYgcmViYXNpbmcgdGFrZXMg eW91IG1vcmUgdGhhbiAyMCBtaW5zLCB5b3UncmUKcHJvYmFibHkgZG9pbmcgaXQgd3JvbmcuIEVu c3VyZSB5b3Ugc3VibWl0IHRoZSBlbnRpcmUgcGF0Y2hzZXQgd2l0aCBhCm5pY2UgY292ZXIgbGV0 dGVyIGFuZCBhbGwgdGhlIHBhdGNoZXMgZGFuZ2xpbmcgKHNoYWxsb3cgdGhyZWFkZWQpIGZyb20K aXQuIElmIHlvdSBkb24ndCBrbm93IGhvdyB0byBkbyB0aGF0IGxvb2sgYXQgYGdpdCBzZW5kLWVt YWlsIC0taGVscGAKYW5kIHNlYXJjaCBmb3IgInRocmVhZCIsICJhbm5vdGF0ZSIgYW5kICJjb21w b3NlIi4gS2VlcCBzdWJtaXR0aW5nCnRoZW0gdG8geW91ciBvd24gKGFuZCBvbmx5IHlvdXIgb3du KSBlbWFpbCBhZGRyZXNzIHVudGlsIGl0IGxvb2tzCmNvcnJlY3QsIF90aGVuXyBzdWJtaXQgdG8g dGhlIE1McyBDQydpbmcgYWxsIG9mIHRoZSBtYWludGFpbmVycyBvbiBhbGwKb2YgdGhlIHBhdGNo ZXMuCgpTdWJtaXNzaW9uIHNob3VsZCBsb29rIGxpa2UgdGhpczoKCiAgW1BBVENIIDAveF0gUGF0 Y2gtc2V0IHRpdGxlCiAgIFwtPltQQVRDSCAxL3hdIG1mZDogUGF0Y2ggdGl0bGUKICAgfC0+W1BB VENIIC4veF0gaHdtb246IFBhdGNoIHRpdGxlCiAgIHwtPltQQVRDSCB4L3hdIGdwaW8vcGluY3Ry bDogUGF0Y2ggdGl0bGUKCldlJ2xsIGdpdmUgeW91IGNvbnN0cnVjdGl2ZSByZXZpZXdzIGFuZCB5 b3UnbGwgYXNrIHF1ZXN0aW9ucyAobm90CmFyZ3VtZW50cykgYW5kIHJlc3VibWl0LgoKLS0gCkxl ZSBKb25lcwpMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFy by5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJv OiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxt LXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xtLXNlbnNvcnM