All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/2] boards.cfg: Delete the equivalent entries
Date: Thu, 13 Feb 2014 14:32:12 +0900	[thread overview]
Message-ID: <20140213143212.97DA.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <20140212141756.37b071ce@lilith>

Hello Albert,


> > There are some entries which produce the same binaries:
> >  - ep8248E           is equivalent to ep8248
> >  - MPC8360ERDK_66    is equivalent to MPC8360ERDK
> >  - Adder87x/AdderUSB is equivalent to Adder
> >  - EVB64260_750CX    is equivalent to EVB64260
> > 
> > I also notice
> >  - Lite5200           is equivalent to icecube_5200
> >  - Lite5200_LOWBOOT   is equivalent to icecube_5200_LOWBOOT
> >  - Lite5200_LOWBOOT08 is equivalent to icecube_5200_LOWBOOT08
> > But I am keeping them.
> > (Wolfgang suggested to do so because Lite5200* are referenced
> > in misc documents.)
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> 
> I wonder (i.e., this is an open question) whether we should delete
> entries for different hardware just because they happen produce
> identical binaries.

In my option, we should not create multiple entries
pointing to the same config header.

We are already using single entry for different boards.
(In such a case, a wildcard character "x" is often used
but it is not must.)
For example, the entry "zynq_zc70x" is used for
both "Zynq ZC702" and "Zynq ZC706" board.
They are definitely different boards but the difference is quite
small. So we can use the same configuration for the two.


In the case of this patch,
(I am not familiar with "ep8248" board, but I guess)
ep8248 and ep8248E are different, but probably similar board.

So we can use the common entry "ep8248" for them.
And "ep8248" means  "ep8248 boards family",
not "exactly ep8248 board".


Best Regards
Masahiro Yamada

  reply	other threads:[~2014-02-13  5:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 11:09 [U-Boot] [PATCH v4 0/2] Refactoring of boards.cfg Masahiro Yamada
2014-01-23 11:09 ` [U-Boot] [PATCH v4 1/2] boards.cfg: Place "-" in the 8th field if it is the same as 7th Masahiro Yamada
2014-02-21 19:57   ` [U-Boot] [U-Boot, v4, " Tom Rini
2014-01-23 11:09 ` [U-Boot] [PATCH v4 2/2] boards.cfg: Delete the equivalent entries Masahiro Yamada
2014-02-12 13:17   ` Albert ARIBAUD
2014-02-13  5:32     ` Masahiro Yamada [this message]
2014-02-13  6:16       ` Albert ARIBAUD
2014-02-13  6:46         ` Masahiro Yamada
2014-02-13  7:48           ` Albert ARIBAUD
2014-02-13  7:24       ` Wolfgang Denk
2014-02-13  8:06         ` Masahiro Yamada
2014-02-21 20:11         ` Tom Rini
2014-02-21 19:57   ` [U-Boot] [U-Boot, v4, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213143212.97DA.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.