From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915: Rename primary plane rotation property to "plane-rotation" Date: Thu, 13 Feb 2014 16:40:23 +0200 Message-ID: <20140213144022.GD3852@intel.com> References: <1392239704-21776-1-git-send-email-ville.syrjala@linux.intel.com> <1392239704-21776-3-git-send-email-ville.syrjala@linux.intel.com> <1392295047.28501.37.camel@sagar-desktop> <20140213134638.GB3852@intel.com> <20140213140631.GC3852@intel.com> <20140213142057.GA32602@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20140213142057.GA32602@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Chris Wilson , Sagar Arun Kamble , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Feb 13, 2014 at 02:20:57PM +0000, Chris Wilson wrote: > On Thu, Feb 13, 2014 at 04:06:31PM +0200, Ville Syrj=E4l=E4 wrote: > > On Thu, Feb 13, 2014 at 03:46:39PM +0200, Ville Syrj=E4l=E4 wrote: > > > On Thu, Feb 13, 2014 at 06:07:27PM +0530, Sagar Arun Kamble wrote: > > > > On Wed, 2014-02-12 at 23:15 +0200, ville.syrjala@linux.intel.com wr= ote: > > > > > From: Ville Syrj=E4l=E4 > > > > > = > > > > > I'd prefer have the crtc "rotation" property rotate the entire cr= tc > > > > > (planes and all). So for that reason we'd need to come up with so= me > > > > > other name for the "rotate the primary plane only" property. > > > > > = > > > > > Originally I had though that omapdrm had already made the decisio= n for > > > > > us, but after another look, it looks like it never attaches the > > > > > "rotation" property to the crtc. So we can still change the name > > > > > without any ABI breakage. > > > > > = > > > > > Suggestions for better naming scheme are also welcome.... > > > > I would suggest name to be "primary-rotation" or "primary_rotation"= . It > > > > seems more aligned to member variable primary_rotation as well. > > > = > > > Well, "primary plane" is an Intel term, so I don't know if other peop= le > > > would find it sensible. But I guess you can consider any plane "prima= ry" > > > if it's assigned to act as the crtc scanout engine... > > = > > It seems I need to scrap this plan actually. Rob hit me with the clue > > bat on irc, and omapdrm does in fact install the "rotation" prop on > > the crtc. So I guess I need to rename the "rotation" prop to something > > else "crtc-rotation" maybe? Anyone have a good name up their sleeve? > = > To recap, you mean that the CRTC rotation property is to be the control > over the rotation of the primary plane, and that we need a new property > name for "rotate the world"? In which case, I'd suggest "rotate-all" > since it seems akin to the action that you take upon setting it (as > opposed to the state of the planes). Yeah something like that. "rotation" vs "rotate-all" isn't super consistent though, but I guess the only real rule about property names is inconsistency, so I'm fine with that idea. -- = Ville Syrj=E4l=E4 Intel OTC