All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v12 7/7] sdl: add support for top-level parallel make
Date: Thu, 13 Feb 2014 15:52:06 +0100	[thread overview]
Message-ID: <20140213155206.25f1d51b@skate> (raw)
In-Reply-To: <1392196751-23485-8-git-send-email-fabio.porcedda@gmail.com>

Dear Fabio Porcedda,

On Wed, 12 Feb 2014 10:19:11 +0100, Fabio Porcedda wrote:
> Add host-autoconf as a dependency of the sdl-patch target because is
> used by it.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  package/sdl/sdl.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> index ba5fbca..701022b 100644
> --- a/package/sdl/sdl.mk
> +++ b/package/sdl/sdl.mk
> @@ -80,3 +80,6 @@ endef
>  SDL_POST_INSTALL_STAGING_HOOKS += SDL_FIXUP_SDL_CONFIG
>  
>  $(eval $(autotools-package))
> +
> +# autoconf is used in the sdl-patch target
> +$(SDL_TARGET_PATCH): | host-autoconf

I believe I'd prefer if the SDL autogen stuff was done as a
pre-configure hook, since this is the hook that is used in the package
infrastructure to run autoreconf in the normal case.

Cc'ing Maxime Hadjinlian, who has recently worked on SDL :)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-02-13 14:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12  9:19 [Buildroot] [PATCH v12 0/7] Add support for top-level parallel make Fabio Porcedda
2014-02-12  9:19 ` [Buildroot] [PATCH v12 1/7] package: add base dependency to every package Fabio Porcedda
2014-02-12  9:19 ` [Buildroot] [PATCH v12 2/7] package: add toolchain dependency to every target package Fabio Porcedda
2014-02-12  9:19 ` [Buildroot] [PATCH v12 3/7] package: add support for top-level parallel make Fabio Porcedda
2014-02-13  6:58   ` Arnout Vandecappelle
2014-02-13  9:13     ` Fabio Porcedda
2014-02-12  9:19 ` [Buildroot] [PATCH v12 4/7] Makefile: " Fabio Porcedda
2014-02-12  9:19 ` [Buildroot] [PATCH v12 5/7] package: enable jobserver for recursive make Fabio Porcedda
2014-02-12  9:19 ` [Buildroot] [PATCH v12 6/7] Makefile: update comment about top-level parallel Makefile Fabio Porcedda
2014-02-12  9:19 ` [Buildroot] [PATCH v12 7/7] sdl: add support for top-level parallel make Fabio Porcedda
2014-02-13 14:52   ` Thomas Petazzoni [this message]
2014-02-14  8:58     ` Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213155206.25f1d51b@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.