From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] arm: dtsi: am335x-bone-common, usb0 is peripheral only Date: Thu, 13 Feb 2014 15:25:52 -0800 Message-ID: <20140213232552.GR28216@atomide.com> References: <1389448851-20010-1-git-send-email-mpa@pengutronix.de> <20140213225438.GF28216@atomide.com> <20140213231333.GK31787@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:35302 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbaBMX0H (ORCPT ); Thu, 13 Feb 2014 18:26:07 -0500 Content-Disposition: inline In-Reply-To: <20140213231333.GK31787@pengutronix.de> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Markus Pargmann Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de * Markus Pargmann [140213 15:16]: > Hi, > > On Thu, Feb 13, 2014 at 02:54:38PM -0800, Tony Lindgren wrote: > > * Markus Pargmann [140111 06:03]: > > > The PMIC is using usb0 vbus line as power source. It is also connected > > > to the am335x processor as vbus sense. But there is no possibility to > > > pullup usb0 vbus to operate as host. This patch fixes the dr_mode of usb0. > > > > That's the MUSB? AFAIK it's not possible to operate MUSB in peripheral > > only mode because the hardware does what it wants based on the ID > > pin state. > > Yes that's MUSB. The am335x reference manual describes that it is > possible to force peripheral/host mode by setting bit 7 (IDDIG_MUX) in > register USBnMODE to 1. Then it uses the bit written in bit 8 (IDDIG) of > register USBnMODE to set host/peripheral mode. OK > I am not sure if the driver supports it yet but I think the DTS should > contain the correct mode nevertheless, especially to avoid starting the > otg loops in the musb driver. Well there's one more thing to consider.. I think in the OTG role change case the VBUS is still driven externally from the original host, so the lack of VBUS does not always mean that host mode should be disabled. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 13 Feb 2014 15:25:52 -0800 Subject: [PATCH] arm: dtsi: am335x-bone-common, usb0 is peripheral only In-Reply-To: <20140213231333.GK31787@pengutronix.de> References: <1389448851-20010-1-git-send-email-mpa@pengutronix.de> <20140213225438.GF28216@atomide.com> <20140213231333.GK31787@pengutronix.de> Message-ID: <20140213232552.GR28216@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Markus Pargmann [140213 15:16]: > Hi, > > On Thu, Feb 13, 2014 at 02:54:38PM -0800, Tony Lindgren wrote: > > * Markus Pargmann [140111 06:03]: > > > The PMIC is using usb0 vbus line as power source. It is also connected > > > to the am335x processor as vbus sense. But there is no possibility to > > > pullup usb0 vbus to operate as host. This patch fixes the dr_mode of usb0. > > > > That's the MUSB? AFAIK it's not possible to operate MUSB in peripheral > > only mode because the hardware does what it wants based on the ID > > pin state. > > Yes that's MUSB. The am335x reference manual describes that it is > possible to force peripheral/host mode by setting bit 7 (IDDIG_MUX) in > register USBnMODE to 1. Then it uses the bit written in bit 8 (IDDIG) of > register USBnMODE to set host/peripheral mode. OK > I am not sure if the driver supports it yet but I think the DTS should > contain the correct mode nevertheless, especially to avoid starting the > otg loops in the musb driver. Well there's one more thing to consider.. I think in the OTG role change case the VBUS is still driven externally from the original host, so the lack of VBUS does not always mean that host mode should be disabled. Regards, Tony