From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WEFS2-0004HH-Mn
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:53:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WEFRw-0000hn-Mi
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:52:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58211)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WEFRw-0000hM-FZ
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 04:52:48 -0500
Date: Fri, 14 Feb 2014 10:52:44 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140214095244.GA12053@stefanha-thinkpad.redhat.com>
References: <52FBB6DD.6090300@msgid.tls.msk.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52FBB6DD.6090300@msgid.tls.msk.ru>
Subject: Re: [Qemu-devel] net: Adding netmap network backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>, Vincenzo Maffione <v.maffione@gmail.com>

On Wed, Feb 12, 2014 at 10:01:01PM +0400, Michael Tokarev wrote:
> After this patch, qemu fails to build on freebsd with the following
> error message:
> 
> net/netmap.c: In function 'netmap_receive_iov':
> net/netmap.c:307: error: 'NS_MOREFRAG' undeclared (first use in this function)
> net/netmap.c:307: error: (Each undeclared identifier is reported only once
> net/netmap.c:307: error: for each function it appears in.)
> net/netmap.c: In function 'netmap_send':
> net/netmap.c:356: error: 'NS_MOREFRAG' undeclared (first use in this function)
> gmake: *** [net/netmap.o] Error 1
> 
> I didn't enable netmap support by default, configure enabled it
> automatically.
> 
> Freebsd has /usr/include/net/netmap.h and netmap_user.h out of the box.
> I've no idea what is inside and how compatible it is with whatever
> qemu expects.
> 
> I had to explicitly use --disable-netmap for qemu to build on freebsd.
> 
> This is FreeBSD 9.1-RELEASE, FWIW.

Vincenzo: Do you need to add a ./configure check so NS_MOREFRAG is only
used when the host kernel supports it?