From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbaBNNdk (ORCPT ); Fri, 14 Feb 2014 08:33:40 -0500 Received: from mail-wi0-f176.google.com ([209.85.212.176]:64371 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752642AbaBNNdh (ORCPT ); Fri, 14 Feb 2014 08:33:37 -0500 Date: Fri, 14 Feb 2014 13:33:30 +0000 From: Lee Jones To: Roger Quadros Cc: tony@atomide.com, bcousson@baylibre.com, balbi@ti.com, nm@ti.com, khilman@linaro.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks Message-ID: <20140214133330.GC13293@lee--X1> References: <1392200333-28397-1-git-send-email-rogerq@ti.com> <1392200333-28397-4-git-send-email-rogerq@ti.com> <20140214100915.GD7380@lee--X1> <52FE164F.80503@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <52FE164F.80503@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> Use a meaningful name for the reference clocks so that it indicates the function. > >> > >> CC: Lee Jones > >> CC: Samuel Ortiz > >> Signed-off-by: Roger Quadros > >> --- > >> drivers/mfd/omap-usb-host.c | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c > >> index 60a3bed..ce620a8 100644 > >> --- a/drivers/mfd/omap-usb-host.c > >> +++ b/drivers/mfd/omap-usb-host.c > >> @@ -714,21 +714,21 @@ static int usbhs_omap_probe(struct platform_device *pdev) > >> goto err_mem; > >> } > >> > >> - omap->xclk60mhsp1_ck = devm_clk_get(dev, "xclk60mhsp1_ck"); > >> + omap->xclk60mhsp1_ck = devm_clk_get(dev, "refclk_60m_ext_p1"); > > > > You can't do that. These changes will have to be in the same patch as > > the core change i.e. where they are initialised. > > I'm not touching them anywhere in this series. When core changes are you > referring to? The ones in: arch/arm/mach-omap2/cclock3xxx_data.c > >> if (IS_ERR(omap->xclk60mhsp1_ck)) { > >> ret = PTR_ERR(omap->xclk60mhsp1_ck); > >> dev_err(dev, "xclk60mhsp1_ck failed error:%d\n", ret); > >> goto err_mem; > >> } > >> > >> - omap->xclk60mhsp2_ck = devm_clk_get(dev, "xclk60mhsp2_ck"); > >> + omap->xclk60mhsp2_ck = devm_clk_get(dev, "refclk_60m_ext_p2"); > >> if (IS_ERR(omap->xclk60mhsp2_ck)) { > >> ret = PTR_ERR(omap->xclk60mhsp2_ck); > >> dev_err(dev, "xclk60mhsp2_ck failed error:%d\n", ret); > >> goto err_mem; > >> } > >> > >> - omap->init_60m_fclk = devm_clk_get(dev, "init_60m_fclk"); > >> + omap->init_60m_fclk = devm_clk_get(dev, "refclk_60m_int"); > >> if (IS_ERR(omap->init_60m_fclk)) { > >> ret = PTR_ERR(omap->init_60m_fclk); > >> dev_err(dev, "init_60m_fclk failed error:%d\n", ret); > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Fri, 14 Feb 2014 13:33:30 +0000 Subject: [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks In-Reply-To: <52FE164F.80503@ti.com> References: <1392200333-28397-1-git-send-email-rogerq@ti.com> <1392200333-28397-4-git-send-email-rogerq@ti.com> <20140214100915.GD7380@lee--X1> <52FE164F.80503@ti.com> Message-ID: <20140214133330.GC13293@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > >> Use a meaningful name for the reference clocks so that it indicates the function. > >> > >> CC: Lee Jones > >> CC: Samuel Ortiz > >> Signed-off-by: Roger Quadros > >> --- > >> drivers/mfd/omap-usb-host.c | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c > >> index 60a3bed..ce620a8 100644 > >> --- a/drivers/mfd/omap-usb-host.c > >> +++ b/drivers/mfd/omap-usb-host.c > >> @@ -714,21 +714,21 @@ static int usbhs_omap_probe(struct platform_device *pdev) > >> goto err_mem; > >> } > >> > >> - omap->xclk60mhsp1_ck = devm_clk_get(dev, "xclk60mhsp1_ck"); > >> + omap->xclk60mhsp1_ck = devm_clk_get(dev, "refclk_60m_ext_p1"); > > > > You can't do that. These changes will have to be in the same patch as > > the core change i.e. where they are initialised. > > I'm not touching them anywhere in this series. When core changes are you > referring to? The ones in: arch/arm/mach-omap2/cclock3xxx_data.c > >> if (IS_ERR(omap->xclk60mhsp1_ck)) { > >> ret = PTR_ERR(omap->xclk60mhsp1_ck); > >> dev_err(dev, "xclk60mhsp1_ck failed error:%d\n", ret); > >> goto err_mem; > >> } > >> > >> - omap->xclk60mhsp2_ck = devm_clk_get(dev, "xclk60mhsp2_ck"); > >> + omap->xclk60mhsp2_ck = devm_clk_get(dev, "refclk_60m_ext_p2"); > >> if (IS_ERR(omap->xclk60mhsp2_ck)) { > >> ret = PTR_ERR(omap->xclk60mhsp2_ck); > >> dev_err(dev, "xclk60mhsp2_ck failed error:%d\n", ret); > >> goto err_mem; > >> } > >> > >> - omap->init_60m_fclk = devm_clk_get(dev, "init_60m_fclk"); > >> + omap->init_60m_fclk = devm_clk_get(dev, "refclk_60m_int"); > >> if (IS_ERR(omap->init_60m_fclk)) { > >> ret = PTR_ERR(omap->init_60m_fclk); > >> dev_err(dev, "init_60m_fclk failed error:%d\n", ret); > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog