From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEJr0-0006nX-N3 for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:35:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEJqs-0005Aq-65 for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:34:58 -0500 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:34569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEJqr-0005Ab-W0 for qemu-devel@nongnu.org; Fri, 14 Feb 2014 09:34:50 -0500 Received: by mail-wi0-f174.google.com with SMTP id f8so530322wiw.1 for ; Fri, 14 Feb 2014 06:34:49 -0800 (PST) Date: Fri, 14 Feb 2014 15:34:46 +0100 From: Stefan Hajnoczi Message-ID: <20140214143446.GH17391@stefanha-thinkpad.redhat.com> References: <52F65880.9000307@redhat.com> <1391878202-27440-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391878202-27440-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qcow2: Set zero flag for discarded clusters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com On Sat, Feb 08, 2014 at 05:50:02PM +0100, Kevin Wolf wrote: > Instead of making the backing file contents visible again after a discard > request, set the zero flag if possible (i.e. on version >= 3). > > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > block/qcow2-cluster.c | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) Thanks, applied v2 to my block tree: https://github.com/stefanha/qemu/commits/block Stefan