From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEKiU-0001ku-Nh
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 10:30:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEKiQ-0007YO-1V
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 10:30:14 -0500
Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:57561)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WEKiP-0007YI-RI
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 10:30:09 -0500
Received: by mail-wg0-f46.google.com with SMTP id x13so492523wgg.1
	for <qemu-devel@nongnu.org>; Fri, 14 Feb 2014 07:30:08 -0800 (PST)
Date: Fri, 14 Feb 2014 16:30:05 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140214153005.GU17391@stefanha-thinkpad.redhat.com>
References: <1392308553-9886-1-git-send-email-benoit.canet@irqsave.net>
	<1392308553-9886-2-git-send-email-benoit.canet@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1392308553-9886-2-git-send-email-benoit.canet@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF
 causing snapshoted quorum to crash on close.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Benoit Canet <benoit@irqsave.net>

On Thu, Feb 13, 2014 at 05:22:33PM +0100, Benoît Canet wrote:
> As bdrv_open() documentation states:
> "The reference to the QDict belongs to the block layer
>  * after the call (even on failure), so if the caller intends to reuse the
>  * dictionary, it needs to use QINCREF() before calling bdrv_open."
> 
> the optional options dict will not be reused after bdrv_open() and should
> belong to the block layer so remove the extra QDECREF(options).
> 
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  blockdev.c | 2 --
>  1 file changed, 2 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan