All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove dead code
Date: Fri, 14 Feb 2014 09:17:08 -0800	[thread overview]
Message-ID: <20140214171708.GA26304@kroah.com> (raw)
In-Reply-To: <1392292818.14949.5.camel@x220>

On Thu, Feb 13, 2014 at 01:00:18PM +0100, Paul Bolle wrote:
> There are a few lines in this driver that depend on a macro
> CONFIG_BT_COEXIST. But there's no Kconfig symbol of that name nor is
> there a preprocessor define for that string. So remove these lines.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Entirely untested.
> 
> Fun fact: two years ago, code depending on the same undefined macro was
> removed from rtl8192cu, see commit 9ef11f7b34c0 ("rtl8192cu: Remove dead
> code never selected"). I wonder where this macro originated.

It comes from the stand-alone version of this driver, and the config
options that it "provides" when building.  So expect it to constantly
show up until this company stops relying on their internal tree...

thanks,

greg k-h

      reply	other threads:[~2014-02-14 17:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 12:00 [PATCH] staging: r8188eu: Remove dead code Paul Bolle
2014-02-14 17:17 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140214171708.GA26304@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.