From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"David S.Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: Add soft module dependency to load HW accelerated crypto modules
Date: Sat, 15 Feb 2014 09:23:14 +0800 [thread overview]
Message-ID: <20140215012314.GA28843@gondor.apana.org.au> (raw)
In-Reply-To: <1392405277.27116.72.camel@schen9-DESK>
On Fri, Feb 14, 2014 at 11:14:37AM -0800, Tim Chen wrote:
> We added the soft module dependency of various crypto algorithm's module alias
> to generic crypto algorithm's module. This loads hardware accelerated
> modules and uses them when available.
>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
I don't see the point of this patch. Any users of these modules
would be requesting for their alias and not their real name. So
either it'll already load all the hardware modules or it won't load
the generic version either.
For example, if you request blowfish you'll get every module that
has the alias blowfish. As the software version is called blowfish_generic
it will be treated no differently than any hardware accelerated
version.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2014-02-15 1:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 19:14 [PATCH] crypto: Add soft module dependency to load HW accelerated crypto modules Tim Chen
2014-02-14 20:28 ` Neil Horman
2014-02-14 21:16 ` Tim Chen
2014-02-17 0:34 ` Rusty Russell
2014-02-17 1:21 ` Marco d'Itri
2014-02-17 1:56 ` Lucas De Marchi
2014-02-15 1:23 ` Herbert Xu [this message]
2014-02-15 2:01 ` Tim Chen
2014-02-15 23:41 ` Herbert Xu
2014-02-17 12:08 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215012314.GA28843@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.