From: Greg KH <gregkh@linuxfoundation.org>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, s-anna@ti.com, tony@atomide.com,
omar.ramirez@copitl.com, loic.pallardy@st.com,
lftan.linux@gmail.com, slapdau@yahoo.com.au,
courtney.cavin@sonymobile.com, rafael.j.wysocki@intel.com
Subject: Re: [PATCHv3 6/6] mailbox: move the internal definitions into a private file
Date: Sat, 15 Feb 2014 11:15:59 -0800 [thread overview]
Message-ID: <20140215191559.GE1801@kroah.com> (raw)
In-Reply-To: <1392488822-18178-1-git-send-email-jaswinder.singh@linaro.org>
On Sat, Feb 15, 2014 at 11:57:02PM +0530, Jassi Brar wrote:
> From: Suman Anna <s-anna@ti.com>
>
> This is needed for extracting the omap_mbox. The OMAP mailbox
> code has a need for exporting some pre-existing API to not
> break the current clients.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
You don't agree with this patch and sign off on it?
> drivers/mailbox/mailbox.c | 62 +-----------------------------
> drivers/mailbox/mailbox_internal.h | 77 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 78 insertions(+), 61 deletions(-)
> create mode 100644 drivers/mailbox/mailbox_internal.h
Why not just do this in the first patch(s)? Why wait for later in the
series to "fix" things up?
thanks,
greg k-h
next prev parent reply other threads:[~2014-02-15 19:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 18:22 [PATCHv3] Generic Mailbox API Jassi Brar
2014-02-15 18:24 ` [PATCHv3 1/6] mailbox: rename pl320-ipc specific mailbox.h Jassi Brar
2014-02-15 18:25 ` [PATCHv3 2/6] mailbox: Introduce a new common API Jassi Brar
2014-02-15 19:03 ` Greg KH
2014-02-15 19:04 ` Greg KH
2014-02-15 19:05 ` Greg KH
2014-02-15 19:15 ` Greg KH
2014-02-16 6:36 ` Jassi Brar
2014-02-16 16:36 ` Greg KH
2014-02-18 0:52 ` Courtney Cavin
2014-02-18 7:06 ` Jassi Brar
2014-02-18 17:30 ` Bjorn Andersson
2014-02-18 18:33 ` Jassi Brar
2014-02-18 19:47 ` Courtney Cavin
2014-02-19 21:43 ` Jassi Brar
2014-02-18 21:32 ` Kumar Gala
2014-02-19 10:53 ` Jassi Brar
2014-02-15 18:25 ` [PATCHv3 3/6] mailbox: pl320: Introduce common API driver Jassi Brar
2014-02-15 18:26 ` [PATCHv3 4/6] mailbox: Fix TX completion init Jassi Brar
2014-02-15 18:26 ` [PATCHv3 5/6] mailbox: Fix deleteing poll timer Jassi Brar
2014-02-15 18:27 ` [PATCHv3 6/6] mailbox: move the internal definitions into a private file Jassi Brar
2014-02-15 19:15 ` Greg KH [this message]
2014-02-15 19:16 ` Greg KH
2014-02-16 6:38 ` Jassi Brar
2014-02-17 5:57 ` [PATCHv3] Generic Mailbox API Craig McGeachie
2014-02-17 6:02 ` Jassi Brar
2014-02-17 6:03 ` Craig McGeachie
2014-02-17 6:12 ` Jassi Brar
2014-03-06 3:55 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215191559.GE1801@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=courtney.cavin@sonymobile.com \
--cc=jassisinghbrar@gmail.com \
--cc=lftan.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=omar.ramirez@copitl.com \
--cc=rafael.j.wysocki@intel.com \
--cc=s-anna@ti.com \
--cc=slapdau@yahoo.com.au \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.