All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFC PATCH nft userspace] nft: connlabel matching support
Date: Sun, 16 Feb 2014 11:33:17 +0000	[thread overview]
Message-ID: <20140216113316.GA1104@macbook.localnet> (raw)
In-Reply-To: <20140216112739.GF28751@breakpoint.cc>

On Sun, Feb 16, 2014 at 12:27:39PM +0100, Florian Westphal wrote:
> Patrick McHardy <kaber@trash.net> wrote:
> 
> > > Could probably be fixed by having my own parsing
> > > function instead of reusing the rt_symbol_table one, but I would
> > > need to replace the uint64_t value in the sym table structure
> > > for that [need to be able to store (1<<127)]...
> > 
> > I see. Actually I think we could change the rt_parse_symbol function
> > to generate bitmasks in case of basetype == bitmask_type.
> 
> Ok.  I'll look into this, but, as I said I would have to replace
> uint64_t with mpz_t to get the wider range required.

Not sure if that will even work since those types have dynamic sizes.

If you keep your own functions (which seem to make sense), they should
only parse and print a single value at a time, handling lists and bitmasks
is done by the generic code - at least it should be :)

  reply	other threads:[~2014-02-16 11:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15 22:47 [RFC PATCH nft userspace] nft: connlabel matching support Florian Westphal
2014-02-16  8:53 ` Patrick McHardy
2014-02-16 11:01   ` Florian Westphal
2014-02-16 11:12     ` Patrick McHardy
2014-02-16 11:27       ` Florian Westphal
2014-02-16 11:33         ` Patrick McHardy [this message]
2014-02-16 16:59       ` Florian Westphal
2014-02-16 17:23         ` Patrick McHardy
2014-02-16 17:51           ` Florian Westphal
2014-02-16 17:53             ` Patrick McHardy
2014-02-16 20:41               ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140216113316.GA1104@macbook.localnet \
    --to=kaber@trash.net \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.