All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Wolfgang Walter <linux@stwm.de>
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com
Subject: Re: linux 3.13: problems with isatap tunnel device and UFO
Date: Mon, 17 Feb 2014 17:09:16 +0100	[thread overview]
Message-ID: <20140217160916.GE22833@order.stressinduktion.org> (raw)
In-Reply-To: <5911515.kv7YDRiZP1@h2o.as.studentenwerk.mhn.de>

[+Cc Cong Wang]

Hi Cong!

In commit d949d826c09fb ("ipv6: Add generic UDP Tunnel segmentation") you
patched ip6_offload.c:

@@ -126,7 +128,7 @@ static struct sk_buff *ipv6_gso_segment(struct sk_buff *skb,
                ipv6h = ipv6_hdr(skb);
                ipv6h->payload_len = htons(skb->len - skb->mac_len -
                                           sizeof(*ipv6h));
-               if (proto == IPPROTO_UDP) {
+               if (!tunnel && proto == IPPROTO_UDP) {
                        unfrag_ip6hlen = ip6_find_1stfragopt(skb, &prevhdr);
                        fptr = (struct frag_hdr *)(skb_network_header(skb) +
                                unfrag_ip6hlen);


I wonder about the !tunnel exception. This now seems to be a problem in sit
ufo output path, where we don't update fragmentation offsets any more thus
generating invalid frames.

I am not too firm with segmentation in case of tunnels but don't we need to
always update the fragmentation offset no matter what, if upper gso callback
produced more segments?

I'll try to dig deeper...

Thanks,

  Hannes

  reply	other threads:[~2014-02-17 16:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 17:47 linux 3.13: problems with isatap tunnel device and UFO Wolfgang Walter
2014-02-07 17:56 ` Hannes Frederic Sowa
2014-02-07 18:17   ` Wolfgang Walter
2014-02-07 22:22     ` Hannes Frederic Sowa
2014-02-08 23:17       ` Wolfgang Walter
2014-02-11  2:44         ` Hannes Frederic Sowa
2014-02-11 17:42           ` Wolfgang Walter
2014-02-17 16:09             ` Hannes Frederic Sowa [this message]
2014-02-20  2:44               ` Hannes Frederic Sowa
2014-02-20  2:54                 ` Hannes Frederic Sowa
2014-02-21  0:43                 ` Cong Wang
2014-02-21  1:19                   ` Hannes Frederic Sowa
2014-02-23 21:05                     ` [PATCH net] ipv4: ipv6: better estimate tunnel header cut for correct ufo handling Hannes Frederic Sowa
2014-02-23 21:24                       ` [PATCH net v2] " Hannes Frederic Sowa
2014-02-23 23:48                         ` [PATCH net v3] " Hannes Frederic Sowa
2014-02-25 23:27                           ` David Miller
2014-02-26 13:47                             ` Hannes Frederic Sowa
2014-02-26 18:45                               ` David Miller
2014-03-07 14:13                           ` Wolfgang Walter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217160916.GE22833@order.stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=linux@stwm.de \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.