From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753733AbaBQRnq (ORCPT ); Mon, 17 Feb 2014 12:43:46 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:36854 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752583AbaBQRnp (ORCPT ); Mon, 17 Feb 2014 12:43:45 -0500 Date: Mon, 17 Feb 2014 17:42:57 +0000 From: Will Deacon To: AKASHI Takahiro Cc: "viro@zeniv.linux.org.uk" , "eparis@redhat.com" , "rgb@redhat.com" , Catalin Marinas , "arndb@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" , "linux-audit@redhat.com" , "patches@linaro.org" Subject: Re: [PATCH v4 3/3] arm64: audit: Add audit hook in ptrace/syscall_trace Message-ID: <20140217174257.GE26590@mudshark.cambridge.arm.com> References: <1391410590-4884-1-git-send-email-takahiro.akashi@linaro.org> <1391767803-5350-1-git-send-email-takahiro.akashi@linaro.org> <1391767803-5350-4-git-send-email-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391767803-5350-4-git-send-email-takahiro.akashi@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 07, 2014 at 10:10:03AM +0000, AKASHI Takahiro wrote: > This patch adds auditing functions on entry to or exit from > every system call invocation. > > Signed-off-by: AKASHI Takahiro > --- > arch/arm64/kernel/ptrace.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c > index 64ce39f..8cdba09 100644 > --- a/arch/arm64/kernel/ptrace.c > +++ b/arch/arm64/kernel/ptrace.c > @@ -19,6 +19,7 @@ > * along with this program. If not, see . > */ > > +#include > #include > #include > #include > @@ -38,6 +39,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1076,10 +1078,15 @@ asmlinkage int syscall_trace(int dir, struct pt_regs *regs) > } > > if (dir) { > + audit_syscall_exit(regs); > tracehook_report_syscall_exit(regs, 0); > } else { > if (tracehook_report_syscall_entry(regs)) > regs->syscallno = ~0UL; > + audit_syscall_entry(syscall_get_arch(current, regs), > + (int)regs->syscallno, > + regs->orig_x0, regs->regs[1], > + regs->regs[2], regs->regs[3]); Again, I don't think we should just lump tracehook and audit together like this without checking the flags (see my reply to the previous patch series). Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v4 3/3] arm64: audit: Add audit hook in ptrace/syscall_trace Date: Mon, 17 Feb 2014 17:42:57 +0000 Message-ID: <20140217174257.GE26590@mudshark.cambridge.arm.com> References: <1391410590-4884-1-git-send-email-takahiro.akashi@linaro.org> <1391767803-5350-1-git-send-email-takahiro.akashi@linaro.org> <1391767803-5350-4-git-send-email-takahiro.akashi@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1391767803-5350-4-git-send-email-takahiro.akashi@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: AKASHI Takahiro Cc: "viro@zeniv.linux.org.uk" , "eparis@redhat.com" , "rgb@redhat.com" , Catalin Marinas , "arndb@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" , "linux-audit@redhat.com" , "patches@linaro.org" List-Id: linux-audit@redhat.com On Fri, Feb 07, 2014 at 10:10:03AM +0000, AKASHI Takahiro wrote: > This patch adds auditing functions on entry to or exit from > every system call invocation. > > Signed-off-by: AKASHI Takahiro > --- > arch/arm64/kernel/ptrace.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c > index 64ce39f..8cdba09 100644 > --- a/arch/arm64/kernel/ptrace.c > +++ b/arch/arm64/kernel/ptrace.c > @@ -19,6 +19,7 @@ > * along with this program. If not, see . > */ > > +#include > #include > #include > #include > @@ -38,6 +39,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1076,10 +1078,15 @@ asmlinkage int syscall_trace(int dir, struct pt_regs *regs) > } > > if (dir) { > + audit_syscall_exit(regs); > tracehook_report_syscall_exit(regs, 0); > } else { > if (tracehook_report_syscall_entry(regs)) > regs->syscallno = ~0UL; > + audit_syscall_entry(syscall_get_arch(current, regs), > + (int)regs->syscallno, > + regs->orig_x0, regs->regs[1], > + regs->regs[2], regs->regs[3]); Again, I don't think we should just lump tracehook and audit together like this without checking the flags (see my reply to the previous patch series). Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Mon, 17 Feb 2014 17:42:57 +0000 Subject: [PATCH v4 3/3] arm64: audit: Add audit hook in ptrace/syscall_trace In-Reply-To: <1391767803-5350-4-git-send-email-takahiro.akashi@linaro.org> References: <1391410590-4884-1-git-send-email-takahiro.akashi@linaro.org> <1391767803-5350-1-git-send-email-takahiro.akashi@linaro.org> <1391767803-5350-4-git-send-email-takahiro.akashi@linaro.org> Message-ID: <20140217174257.GE26590@mudshark.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 07, 2014 at 10:10:03AM +0000, AKASHI Takahiro wrote: > This patch adds auditing functions on entry to or exit from > every system call invocation. > > Signed-off-by: AKASHI Takahiro > --- > arch/arm64/kernel/ptrace.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c > index 64ce39f..8cdba09 100644 > --- a/arch/arm64/kernel/ptrace.c > +++ b/arch/arm64/kernel/ptrace.c > @@ -19,6 +19,7 @@ > * along with this program. If not, see . > */ > > +#include > #include > #include > #include > @@ -38,6 +39,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1076,10 +1078,15 @@ asmlinkage int syscall_trace(int dir, struct pt_regs *regs) > } > > if (dir) { > + audit_syscall_exit(regs); > tracehook_report_syscall_exit(regs, 0); > } else { > if (tracehook_report_syscall_entry(regs)) > regs->syscallno = ~0UL; > + audit_syscall_entry(syscall_get_arch(current, regs), > + (int)regs->syscallno, > + regs->orig_x0, regs->regs[1], > + regs->regs[2], regs->regs[3]); Again, I don't think we should just lump tracehook and audit together like this without checking the flags (see my reply to the previous patch series). Will