From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 17 Feb 2014 22:11:17 +0100
Subject: [U-Boot] [PATCH v2 3/7] usb: eth: introduce support for Moschip
	USB ethernet
In-Reply-To: <1392665727-5734-4-git-send-email-gsi@denx.de>
References: <1392665727-5734-1-git-send-email-gsi@denx.de>
	<1392665727-5734-4-git-send-email-gsi@denx.de>
Message-ID: <20140217211117.4D814381337@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Gerhard,

In message <1392665727-5734-4-git-send-email-gsi@denx.de> you wrote:
> introduce an 'mcs7830' driver for Moschip based USB ethernet adapters,
> which was implemented based on the U-Boot Asix driver with additional
> information gathered from the Moschip Linux driver
...
> +/* bit masks and default values for the above registers */
> +#define PHY_CMD1_READ		BIT(6)
> +#define PHY_CMD1_WRITE		BIT(5)
> +#define PHY_CMD1_PHYADDR	BIT(0)
> +
> +#define PHY_CMD2_PEND		BIT(7)
> +#define PHY_CMD2_READY		BIT(6)
...

As mentioned in patch # 1, I object against the use of these
obfuscating BIT() macros.  Please do not use these; use plain
readable code, that leaves no ambiguities to the reader.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Just because your doctor has a name for your condition  doesn't  mean
he knows what it is.