From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 17 Feb 2014 22:22:38 +0100
Subject: [U-Boot] [PATCH v2 3/7] usb: eth: introduce support for Moschip
	USB ethernet
In-Reply-To: <20140217211117.4D814381337@gemini.denx.de>
References: <1392665727-5734-1-git-send-email-gsi@denx.de>
	<1392665727-5734-4-git-send-email-gsi@denx.de>
	<20140217211117.4D814381337@gemini.denx.de>
Message-ID: <201402172222.38911.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, February 17, 2014 at 10:11:17 PM, Wolfgang Denk wrote:
> Dear Gerhard,
> 
> In message <1392665727-5734-4-git-send-email-gsi@denx.de> you wrote:
> > introduce an 'mcs7830' driver for Moschip based USB ethernet adapters,
> > which was implemented based on the U-Boot Asix driver with additional
> > information gathered from the Moschip Linux driver
> 
> ...
> 
> > +/* bit masks and default values for the above registers */
> > +#define PHY_CMD1_READ		BIT(6)
> > +#define PHY_CMD1_WRITE		BIT(5)
> > +#define PHY_CMD1_PHYADDR	BIT(0)
> > +
> > +#define PHY_CMD2_PEND		BIT(7)
> > +#define PHY_CMD2_READY		BIT(6)
> 
> ...
> 
> As mentioned in patch # 1, I object against the use of these
> obfuscating BIT() macros.  Please do not use these; use plain
> readable code, that leaves no ambiguities to the reader.

Just to chime in real quick, Linux uses these 'BIT()' macros, but I personally 
have no hard feelings about them either way.

Best regards,
Marek Vasut