From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbaBQXOB (ORCPT ); Mon, 17 Feb 2014 18:14:01 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:58695 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbaBQXN7 (ORCPT ); Mon, 17 Feb 2014 18:13:59 -0500 Date: Mon, 17 Feb 2014 23:13:19 +0000 From: One Thousand Gnomes To: Tommie Gannert Cc: Samuel Ortiz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] irtty-sir.c: Do not set_termios() on irtty_close() Message-ID: <20140217231319.5545dac1@alan.etchedpixels.co.uk> In-Reply-To: <5302750C.6080407@gannert.se> References: <52FC87B6.4070001@gannert.se> <5302750C.6080407@gannert.se> Organization: Intel Corporation X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > v2: Resend due to mail format issues. More Thunderbird settings applied. > > I know very little of this code, and I'm not sure this is a good solution, > so here's some background: I wouldn't worry too much. I'm amazed the code even works these days. It's incredibly bitrotted and doesn't use the tty layer properly (mind you it never did) > The effect of this is that /dev/ttyUSB* is still in use, and thus leaking > at least dev nodes. This is a minimal patch that solves that oops. > --- linux-3.12/drivers/net/irda/irtty-sir.c.orig 2014-02-12 21:36:46.132496089 +0000 > +++ linux-3.12/drivers/net/irda/irtty-sir.c 2014-02-12 21:57:21.635843884 +0000 > @@ -521,7 +521,6 @@ static void irtty_close(struct tty_struc > sirdev_put_instance(priv->dev); > > /* Stop tty */ > - irtty_stop_receiver(tty, TRUE); > clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags); > if (tty->ops->stop) > tty->ops->stop(tty); This change looks correct to me. The three lines below your change are amusing all incorrect and should probably also all be deleted. Alan