Re: [PATCH 1/4] ASoC: ssm2602: Split SPI and I2C code into different modules

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1317 bytes --]

On Mon, Feb 17, 2014 at 01:16:53PM +0100, Lars-Peter Clausen wrote:
> There are a few known (minor) problems with having the support code for both I2C
> and SPI in the same module:
>     * We need to be extra careful to make sure to not build the driver into the
>       kernel if one of the subsystems is build as a module (Currently only SPI
>       can be build as a module).

I2C not SPI.

> This patch splits the AD193X driver into 3 modules. One core module that
> implements the device logic, but is independent of the bus method used. And one
> module for SPI and I2C each that registers the drivers and sets up the regmap
> struct for the bus.

No it doesn't, it splits the ssm2602 driver.

> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  sound/soc/blackfin/Kconfig     |   3 +-
>  sound/soc/codecs/Kconfig       |  11 ++-
>  sound/soc/codecs/Makefile      |   4 ++
>  sound/soc/codecs/ssm2602-i2c.c |  57 +++++++++++++++
>  sound/soc/codecs/ssm2602-spi.c |  41 +++++++++++
>  sound/soc/codecs/ssm2602.c     | 158 ++++++-----------------------------------
>  sound/soc/codecs/ssm2602.h     |  14 ++++

There also seem to be a bunch of arch/blackfin references to do this -
they should stay OK due to the select but it might be worth updating
them.

I'll apply this with the commit log edited.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]