From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40861)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WFjq2-00022N-G1
	for qemu-devel@nongnu.org; Tue, 18 Feb 2014 07:31:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WFjpu-0002Nw-1T
	for qemu-devel@nongnu.org; Tue, 18 Feb 2014 07:31:50 -0500
Received: from lnantes-156-75-100-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:33594 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WFjpt-0002Nn-R0
	for qemu-devel@nongnu.org; Tue, 18 Feb 2014 07:31:41 -0500
Date: Tue, 18 Feb 2014 13:31:40 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140218123140.GC18400@irqsave.net>
References: <1392242799-16364-1-git-send-email-benoit.canet@irqsave.net>
	<1392242799-16364-12-git-send-email-benoit.canet@irqsave.net>
	<20140213090949.GB3119@irqsave.net>
	<20140218040657.GA7579@T430.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140218040657.GA7579@T430.redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and
	quorum_close().
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com

The Tuesday 18 Feb 2014 =E0 12:06:57 (+0800), Fam Zheng wrote :
> On Thu, 02/13 10:09, Beno=EEt Canet wrote:
> > The Wednesday 12 Feb 2014 =E0 23:06:38 (+0100), Beno=EEt Canet wrote =
:
> > > +static void quorum_close(BlockDriverState *bs)
> > > +{
> > > +    BDRVQuorumState *s =3D bs->opaque;
> > > +    int i;
> > > +
> > > +    for (i =3D 0; i < s->num_children; i++) {
> > > +        bdrv_unref(s->bs[i]);
> > Quorum crash here from time to time I don't understand why.
>=20
> I think you could add printf or use gdb to examine every bdrv_unref on =
the
> crashing bs, so you can track down to the unbalanced reference.

I found the cause of the crash since: I added a spurious QDECREF() in the
external snapshot prepare function.
It's fixed now.

Thanks,

Beno=EEt

>=20
> Fam