From: Jean Delvare <jdelvare@suse.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/3] hwmon: (lm90) Create all sysfs groups in one call
Date: Tue, 18 Feb 2014 14:56:17 +0000 [thread overview]
Message-ID: <20140218155617.658ce9c5@endymion.delvare> (raw)
In-Reply-To: <1392513995-30712-2-git-send-email-linux@roeck-us.net>
On Sat, 15 Feb 2014 17:26:34 -0800, Guenter Roeck wrote:
> Create all sysfs groups in one call by using sysfs_create_groups
> instead of calling sysfs_create_group individually for each group.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/lm90.c | 67 +++++++++++++++++---------------------------------
> 1 file changed, 22 insertions(+), 45 deletions(-)
> (...)
Looks good, except for the "pec" attribute which shouldn't move IMHO.
--
Jean Delvare
Suse L3 Support
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2014-02-18 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 1:26 [lm-sensors] [PATCH 2/3] hwmon: (lm90) Create all sysfs groups in one call Guenter Roeck
2014-02-18 14:56 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218155617.658ce9c5@endymion.delvare \
--to=jdelvare@suse.de \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.