From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Mohit KUMAR DCG <Mohit.KUMAR-qxv4g6HH51o@public.gmane.org>,
Pratyush ANAND <pratyush.anand-qxv4g6HH51o@public.gmane.org>,
Viresh Kumar
<viresh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
spear-devel <spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V6 03/12] phy: st-miphy40lp: Add binding information
Date: Tue, 18 Feb 2014 15:58:14 +0100 [thread overview]
Message-ID: <201402181558.14663.arnd@arndb.de> (raw)
In-Reply-To: <20140218122324.GA23267-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
On Tuesday 18 February 2014, Mark Rutland wrote:
> >
> > - These are Spear SoC specific miscellaneous registers. Here these are used for
> > to configure sata/pcie aux clock.
> > >
> > > > +- phy-id: Instance id of the phy.
> > > > +- #phy-cells : from the generic PHY bindings, must be 1.
> > > > + - 1st cell: phandle to the phy node.
> > > > + - 2nd cell: 0 if phy (in 1st cell) is to be used for SATA, 1 for PCIe
> > > > + and 2 for Super Speed USB.
> > >
> > > One cell or two?
> >
> > - No of cells are two, is this the question?
>
> The description of #phy-cells says it must be 1. Presumably it must be 2.
The description here is counting the phandle, while we normally only
count the arguments following the phandle. #phy-cells=<1> is correct
here, but the description should be written a bit clearer.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-18 14:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 9:29 [PATCH V6 00/12]PCI:Add SPEAr13xx PCie support Mohit Kumar
2014-02-11 9:29 ` Mohit Kumar
2014-02-11 9:29 ` Mohit Kumar
2014-02-11 9:29 ` [PATCH V6 01/12] clk: SPEAr13XX: Fix pcie clock name Mohit Kumar
2014-02-11 9:29 ` [PATCH V6 02/12] SPEAr13XX: Fix static mapping table Mohit Kumar
2014-02-11 9:30 ` [PATCH V6 04/12] phy: st-miphy40lp: Add skeleton driver Mohit Kumar
2014-02-11 11:35 ` Kishon Vijay Abraham I
2014-02-11 11:44 ` Mohit KUMAR DCG
[not found] ` <cover.1392109054.git.mohit.kumar-qxv4g6HH51o@public.gmane.org>
2014-02-11 9:29 ` [PATCH V6 03/12] phy: st-miphy40lp: Add binding information Mohit Kumar
[not found] ` <af50da74226a244dfc05aed3dc9d28b896d166a4.1392109054.git.mohit.kumar-qxv4g6HH51o@public.gmane.org>
2014-02-12 18:20 ` Mark Rutland
[not found] ` <20140212182012.GC23630-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-13 5:19 ` Mohit KUMAR DCG
[not found] ` <2CC2A0A4A178534D93D5159BF3BCB66189FD2CAFB1-8vAmw3ZAcdzhJTuQ9jeba9BPR1lH4CV8@public.gmane.org>
2014-02-18 12:23 ` Mark Rutland
[not found] ` <20140218122324.GA23267-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-18 14:58 ` Arnd Bergmann [this message]
[not found] ` <201402181558.14663.arnd-r2nGTMty4D4@public.gmane.org>
2014-02-21 15:25 ` Mark Rutland
2014-02-11 9:30 ` [PATCH V6 05/12] SPEAr: misc: " Mohit Kumar
[not found] ` <bfddafffd103bef179fef717793bf94652742b85.1392109054.git.mohit.kumar-qxv4g6HH51o@public.gmane.org>
2014-02-12 18:21 ` Mark Rutland
[not found] ` <20140212182101.GD23630-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-13 5:25 ` Mohit KUMAR DCG
2014-02-11 9:30 ` [PATCH V6 08/12] SPEAr13xx: Add binding information for PCIe controller Mohit Kumar
2014-02-11 9:30 ` [PATCH V6 06/12] SPEAr13xx: Fixup: Move SPEAr1340 SATA platform code to phy driver Mohit Kumar
2014-02-11 9:30 ` Mohit Kumar
2014-02-11 11:35 ` Kishon Vijay Abraham I
2014-02-11 11:35 ` Kishon Vijay Abraham I
2014-02-11 11:50 ` Mohit KUMAR DCG
2014-02-11 9:30 ` [PATCH V6 07/12] phy: st-miphy-40lp: Add SPEAr1310 and SPEAr1340 PCIe phy support Mohit Kumar
2014-02-11 9:30 ` Mohit Kumar
2014-02-11 12:06 ` Kishon Vijay Abraham I
2014-02-11 12:06 ` Kishon Vijay Abraham I
2014-02-12 4:07 ` Mohit KUMAR DCG
2014-02-12 4:07 ` Mohit KUMAR DCG
2014-02-11 9:30 ` [PATCH V6 09/12] SPEAr13XX: dts: Add PCIe node information Mohit Kumar
2014-02-11 9:30 ` [PATCH V6 10/12] pcie: SPEAr13xx: Add designware wrapper support Mohit Kumar
2014-02-11 9:30 ` [PATCH V6 11/12] SPEAr13xx: defconfig: Update Mohit Kumar
2014-02-11 9:30 ` [PATCH V6 12/12] MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer Mohit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402181558.14663.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=Mohit.KUMAR-qxv4g6HH51o@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pratyush.anand-qxv4g6HH51o@public.gmane.org \
--cc=spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org \
--cc=viresh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.