From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC v2 1/4] bridge: enable interfaces to opt out from becoming the root bridge Date: Wed, 19 Feb 2014 09:08:55 -0800 Message-ID: <20140219090855.610c0e04__34172.6098944948$1392829849$gmane$org@nehalam.linuxnetplumber.net> References: <1392433180-16052-1-git-send-email-mcgrof@do-not-panic.com> <1392433180-16052-2-git-send-email-mcgrof@do-not-panic.com> <20140216105754.63738163@nehalam.linuxnetplumber.net> <1392803559.23084.99.camel@kazak.uk.xensource.com> <5304C13F.3030802@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WGAdq-0003SN-Tv for xen-devel@lists.xenproject.org; Wed, 19 Feb 2014 17:09:03 +0000 Received: by mail-pd0-f173.google.com with SMTP id y10so623588pdj.18 for ; Wed, 19 Feb 2014 09:08:59 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Luis R. Rodriguez" Cc: Ian Campbell , kvm@vger.kernel.org, "netdev@vger.kernel.org" , bridge@lists.linux-foundation.org, "linux-kernel@vger.kernel.org" , Zoltan Kiss , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, 19 Feb 2014 09:02:06 -0800 "Luis R. Rodriguez" wrote: > Folks, what if I repurpose my patch to use the IFF_BRIDGE_NON_ROOT (or > relabel to IFF_ROOT_BLOCK_DEF) flag for a default driver preference > upon initialization so that root block will be used once the device > gets added to a bridge. The purpose would be to avoid drivers from > using the high MAC address hack, streamline to use a random MAC > address thereby avoiding the possible duplicate address situation for > IPv6. In the STP use case for these interfaces we'd just require > userspace to unset the root block. I'd consider the STP use case the > most odd of all. The caveat to this approach is 3.8 would be needed > (or its the root block patches cherry picked) for base kernels older > than 3.8. > > Stephen? > > Luis Don't add IFF_ flags that adds yet another API hook into bridge. Please only use the netlink/sysfs flags fields that already exist for new features.