[U-Boot] [RFC PATCH 1/3] add file with a default boot environment based heavily on Stephen Warrens recent tegra work.

From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/3] add file with a default boot environment based heavily on Stephen Warrens recent tegra work.
Date: Wed, 19 Feb 2014 08:42:57 -0500	[thread overview]
Message-ID: <20140219134257.GK19081@bill-the-cat> (raw)
In-Reply-To: <1392659798-1665-2-git-send-email-dennis@ausil.us>

On Mon, Feb 17, 2014 at 11:56:36AM -0600, Dennis Gilmore wrote:

> Signed-off-by: Dennis Gilmore <dennis@ausil.us>
[snip]
> +		"if ${usb_need_init}; then " \
> +			"set usb_need_init false; " \
> +			"usb start 0; " \

Checking common/cmd_usb.c, 'start' doesn't take arguments.

> +#ifdef CONFIG_CMD_SATA
> +#define BOOTCMDS_SATA \
> +	"sata_boot=" \
> +		"setenv devtype sata; " \
> +		"if sata dev ${devnum}; then " \
> +			"run scan_boot; " \
> +		"fi\0" \
> +	\
> +	"bootcmd_sata0=setenv devnum 0; run sata_boot;\0"
> +	"bootcmd_sata1=setenv devnum 1; run sata_boot;\0"
> +#define BOOT_TARGETS_USB "sata0 sata1"

Typo, s/USB/SATA/

> +#ifdef CONFIG_CMD_DHCP
> +#define BOOTCMDS_DHCP \
> +	"bootcmd_dhcp=" \
> +		BOOTCMD_INIT_USB \

Why BOOTCMD_INIT_USB here?  For USB based networking?  If so, add some
comments please.

> +		"if dhcp ${scriptaddr} boot.scr.uimg; then "\
> +			"source ${scriptaddr}; " \
> +		"fi\0"

This relies on autoload being true, so we should set that.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140219/94d8d906/attachment.pgp>