From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Florian Westphal <fw@strlen.de>,
Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH -next] net: tcp: add mib counters to track zero window transitions
Date: Wed, 19 Feb 2014 20:32:13 +0100 [thread overview]
Message-ID: <20140219193213.GD1179@order.stressinduktion.org> (raw)
In-Reply-To: <20140219193038.GC1179@order.stressinduktion.org>
Sorry...
On Wed, Feb 19, 2014 at 08:30:38PM +0100, Hannes Frederic Sowa wrote:
> NET_STATS only use 32 bit counter and thus need not be protected with a
> seqlock on 32 bit platforms. As such, it does not matter, but e.g. the IP
> counter are prone to deadlocks if used with wrong postfix because of 64 bit
> counter thus protected by seqlock.
>
> A pitty that the _STATS_BH postfixes have the opposite meaning of the bottom
s/bottom$/locking/
> _bh postfixes.
>
> Basically always safe is _STATS and if we are sure we can omit the bh disable
> call because we only call the function from bh, we can use _STATS_BH calls.
Should read mails again before sending. ;)
next prev parent reply other threads:[~2014-02-19 19:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 21:57 [PATCH -next] net: tcp: add mib counters to track zero window transitions Florian Westphal
2014-02-19 18:17 ` David Miller
2014-02-19 18:49 ` Eric Dumazet
2014-02-19 18:59 ` Hannes Frederic Sowa
2014-02-19 19:06 ` Hannes Frederic Sowa
2014-02-19 19:18 ` Florian Westphal
2014-02-19 19:27 ` Eric Dumazet
2014-02-19 19:30 ` Hannes Frederic Sowa
2014-02-19 19:32 ` Hannes Frederic Sowa [this message]
2014-02-19 19:46 ` Eric Dumazet
2014-02-25 12:31 ` [PATCH] net: tcp: use NET_INC_STATS() Eric Dumazet
2014-02-26 20:20 ` David Miller
2014-02-25 0:14 ` [PATCH -next] net: tcp: add mib counters to track zero window transitions David Miller
2014-02-25 8:23 ` Florian Westphal
2014-02-25 12:24 ` Eric Dumazet
2014-02-25 12:34 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219193213.GD1179@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.