From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm64: mm: Route pmd thp functions through pte equivalents
Date: Thu, 20 Feb 2014 17:00:36 +0000 [thread overview]
Message-ID: <20140220170035.GB7651@arm.com> (raw)
In-Reply-To: <20140212103237.GA12778@linaro.org>
On Wed, Feb 12, 2014 at 10:32:38AM +0000, Steve Capper wrote:
> On Wed, Feb 12, 2014 at 10:14:23AM +0000, Catalin Marinas wrote:
> > On Thu, Feb 06, 2014 at 02:16:10PM +0000, Steve Capper wrote:
> > > Rather than have separate hugetlb and transparent huge page pmd
> > > manipulation functions, re-wire our thp functions to simply call the
> > > pte equivalents.
> >
> > That's one thing I don't like about hugetlb, casting pmds to ptes. Do we
> > actually save much in terms of code clean-up by doing this?
>
> At the moment we have ptes and hugetlb ptes behaving in the same way so
> they both make use of PTE_WRITE. I thought it would be more logical to
> tie the THP code to the pte manipulation functions too rather than
> duplicate the PTE_WRITE logic in a separate PMD_WRITE. This makes
> future pte changes apply to THP too automatically (along with hugetlb).
OK, let's go with this, it's difficult to change hugetlb the other way.
BTW, powerpc and tile heavily simplify this using macros and
pte_pmd/pmd_pte macros.
--
Catalin
next prev parent reply other threads:[~2014-02-20 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 14:16 [PATCH 0/3] arm64: Use pte manipulation functions for THP Steve Capper
2014-02-06 14:16 ` [PATCH 1/3] arm64: mm: Remove PMD_BIT_FUNC macro Steve Capper
2014-02-06 14:16 ` [PATCH 2/3] arm64: mm: Route pmd thp functions through pte equivalents Steve Capper
2014-02-12 10:14 ` Catalin Marinas
2014-02-12 10:32 ` Steve Capper
2014-02-20 17:00 ` Catalin Marinas [this message]
2014-02-06 14:16 ` [PATCH 3/3] arm64: mm: Correct definition of pmd_mknotpresent Steve Capper
2014-02-12 9:43 ` [PATCH 0/3] arm64: Use pte manipulation functions for THP Steve Capper
2014-02-12 10:07 ` Will Deacon
2014-02-12 10:16 ` Catalin Marinas
2014-02-12 10:21 ` Will Deacon
2014-02-12 11:50 ` Steve Capper
2014-02-12 12:43 ` Russell King - ARM Linux
2014-02-12 13:47 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220170035.GB7651@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.