From: Jean Delvare <jdelvare@suse.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH 1/2] mtd/ts5500: Add dependency
Date: Sun, 23 Feb 2014 10:27:56 +0100 [thread overview]
Message-ID: <20140223102756.506da111@endymion.delvare> (raw)
In-Reply-To: <20140223020119.GA11836@norris-Latitude-E6410>
Hi Brian,
On Sat, 22 Feb 2014 18:01:19 -0800, Brian Norris wrote:
> On Fri, Feb 14, 2014 at 11:28:24AM +0100, Jean Delvare wrote:
> > There is no point in displaying the TS5500-specific driver entries if
> > TS5500 board support itself isn't enabled.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > ---
> > drivers/mtd/maps/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig 2014-02-14 11:21:15.116363700 +0100
> > +++ linux-3.14-rc2/drivers/mtd/maps/Kconfig 2014-02-14 11:23:53.286863374 +0100
> > @@ -124,7 +124,7 @@ config MTD_NETSC520
> >
> > config MTD_TS5500
> > tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
> > - depends on X86
> > + depends on TS5500 || (X86 && COMPILE_TEST)
>
> Shouldn't this just be
>
> depends on TS5500 || COMPILE_TEST
>
> since it's such a simple driver, it can be compiled under any ARCH?
Could be. As I didn't have any other architecture to test on, I decided
to play it safe and assumed the dependency on X86 was there for a
reason. Looking at the code again, you appear to be right, there
doesn't seem to be a need to restrict compilation testing to X86.
I'll send an updated patch, thanks for the suggestion.
> > select MTD_JEDECPROBE
> > select MTD_CFI_AMDSTD
> > help
> >
> >
--
Jean Delvare
Suse L3 Support
prev parent reply other threads:[~2014-02-23 9:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 10:28 [PATCH 1/2] mtd/ts5500: Add dependency Jean Delvare
2014-02-14 10:32 ` Alexander Shiyan
2014-02-14 10:44 ` Jean Delvare
2014-02-14 10:56 ` Alexander Shiyan
2014-02-14 10:32 ` [PATCH 2/2] gpio-ts5500: " Jean Delvare
2014-02-22 2:00 ` Alexandre Courbot
2014-02-27 9:20 ` Linus Walleij
2014-02-23 2:01 ` [PATCH 1/2] mtd/ts5500: " Brian Norris
2014-02-23 9:27 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223102756.506da111@endymion.delvare \
--to=jdelvare@suse.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.