diff for duplicates of <20140223212737.214342433@linutronix.de>
diff --git a/a/1.txt b/N1/1.txt
index 675c584..5c529de 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -1,102 +1,3 @@
-The pm-mmp2 and pm-pxa910 power management related irq_set_wake
-callbacks fiddle pointlessly with the irq actions for no reason except
-for lack of understanding how the wakeup mechanism works.
-
-On supsend the core disables all interrupts lazily, i.e. it does not
-mask them at the irq controller level. So any interrupt which is
-firing during supsend will mark the corresponding interrupt line as
-pending. Just before the core powers down it checks whether there are
-interrupts pending from interrupt lines which are marked as wakeup
-sources and if so it aborts the resume and resends the interrupts.
-
-The IRQF_NO_SUSPEND flag for interrupt actions is a totally different
-mechanism. That allows the device driver to prevent the core from
-disabling the interrupt despite the fact that it is not marked as a
-wakeup source. This has nothing to do with the case at hand. It was
-introduced for special cases where lazy disable is not possible.
-
-Remove the nonsense along with the braindamaged boundary check. The
-core code does NOT call these functions out of boundary.
-
-Add a FIXME comment to an unhandled error path which merily printks
-some useless blurb instead of returning a proper error code.
-
-Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-Cc: arm <linux-arm-kernel@lists.infradead.org>
-Cc: Eric Miao <eric.y.miao@gmail.com>
-Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
-Cc: Russell King <linux@arm.linux.org.uk>
----
- arch/arm/mach-mmp/pm-mmp2.c | 16 +---------------
- arch/arm/mach-mmp/pm-pxa910.c | 20 ++++----------------
- 2 files changed, 5 insertions(+), 31 deletions(-)
-
-Index: tip/arch/arm/mach-mmp/pm-mmp2.c
-===================================================================
---- tip.orig/arch/arm/mach-mmp/pm-mmp2.c
-+++ tip/arch/arm/mach-mmp/pm-mmp2.c
-@@ -27,22 +27,8 @@
-
- int mmp2_set_wake(struct irq_data *d, unsigned int on)
- {
-- int irq = d->irq;
-- struct irq_desc *desc = irq_to_desc(irq);
- unsigned long data = 0;
--
-- if (unlikely(irq >= nr_irqs)) {
-- pr_err("IRQ nubmers are out of boundary!\n");
-- return -EINVAL;
-- }
--
-- if (on) {
-- if (desc->action)
-- desc->action->flags |= IRQF_NO_SUSPEND;
-- } else {
-- if (desc->action)
-- desc->action->flags &= ~IRQF_NO_SUSPEND;
-- }
-+ int irq = d->irq;
-
- /* enable wakeup sources */
- switch (irq) {
-Index: tip/arch/arm/mach-mmp/pm-pxa910.c
-===================================================================
---- tip.orig/arch/arm/mach-mmp/pm-pxa910.c
-+++ tip/arch/arm/mach-mmp/pm-pxa910.c
-@@ -27,22 +27,8 @@
-
- int pxa910_set_wake(struct irq_data *data, unsigned int on)
- {
-- int irq = data->irq;
-- struct irq_desc *desc = irq_to_desc(data->irq);
- uint32_t awucrm = 0, apcr = 0;
--
-- if (unlikely(irq >= nr_irqs)) {
-- pr_err("IRQ nubmers are out of boundary!\n");
-- return -EINVAL;
-- }
--
-- if (on) {
-- if (desc->action)
-- desc->action->flags |= IRQF_NO_SUSPEND;
-- } else {
-- if (desc->action)
-- desc->action->flags &= ~IRQF_NO_SUSPEND;
-- }
-+ int irq = data->irq;
-
- /* setting wakeup sources */
- switch (irq) {
-@@ -115,9 +101,11 @@ int pxa910_set_wake(struct irq_data *dat
- if (irq >= IRQ_GPIO_START && irq < IRQ_BOARD_START) {
- awucrm = MPMU_AWUCRM_WAKEUP(2);
- apcr |= MPMU_APCR_SLPWP2;
-- } else
-+ } else {
-+ /* FIXME: This should return a proper error code ! */
- printk(KERN_ERR "Error: no defined wake up source irq: %d\n",
- irq);
-+ }
- }
-
- if (on) {
\ No newline at end of file
+An embedded and charset-unspecified text was scrubbed...
+Name: arm-mmp-remove-idiotic-fiddling-with-irq-internals.patch
+URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140223/ef9b3db6/attachment.ksh>
\ No newline at end of file
diff --git a/a/content_digest b/N1/content_digest
index 9bb8ec8..4ed07ee 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -2,7 +2,7 @@
"ref\00020140223212703.511977310\@linutronix.de\0"
]
[
- "From\0Thomas Gleixner <tglx\@linutronix.de>\0"
+ "From\0tglx\@linutronix.de (Thomas Gleixner)\0"
]
[
"Subject\0[patch 09/26] arm: mmp: Remove pointless fiddling with irq internals\0"
@@ -11,128 +11,18 @@
"Date\0Sun, 23 Feb 2014 21:40:13 -0000\0"
]
[
- "To\0LKML <linux-kernel\@vger.kernel.org>\0"
-]
-[
- "Cc\0Ingo Molnar <mingo\@elte.hu>",
- " Peter Zijlstra <peterz\@infradead.org>",
- " arm <linux-arm-kernel\@lists.infradead.org>",
- " Eric Miao <eric.y.miao\@gmail.com>",
- " Haojian Zhuang <haojian.zhuang\@gmail.com>",
- " Russell King <linux\@arm.linux.org.uk>\0"
+ "To\0linux-arm-kernel\@lists.infradead.org\0"
]
[
"\0000:1\0"
]
-[
- "fn\0arm-mmp-remove-idiotic-fiddling-with-irq-internals.patch\0"
-]
[
"b\0"
]
[
- "The pm-mmp2 and pm-pxa910 power management related irq_set_wake\n",
- "callbacks fiddle pointlessly with the irq actions for no reason except\n",
- "for lack of understanding how the wakeup mechanism works.\n",
- "\n",
- "On supsend the core disables all interrupts lazily, i.e. it does not\n",
- "mask them at the irq controller level. So any interrupt which is\n",
- "firing during supsend will mark the corresponding interrupt line as\n",
- "pending. Just before the core powers down it checks whether there are\n",
- "interrupts pending from interrupt lines which are marked as wakeup\n",
- "sources and if so it aborts the resume and resends the interrupts.\n",
- "\n",
- "The IRQF_NO_SUSPEND flag for interrupt actions is a totally different\n",
- "mechanism. That allows the device driver to prevent the core from\n",
- "disabling the interrupt despite the fact that it is not marked as a\n",
- "wakeup source. This has nothing to do with the case at hand. It was\n",
- "introduced for special cases where lazy disable is not possible.\n",
- "\n",
- "Remove the nonsense along with the braindamaged boundary check. The\n",
- "core code does NOT call these functions out of boundary.\n",
- "\n",
- "Add a FIXME comment to an unhandled error path which merily printks\n",
- "some useless blurb instead of returning a proper error code.\n",
- "\n",
- "Signed-off-by: Thomas Gleixner <tglx\@linutronix.de>\n",
- "Cc: arm <linux-arm-kernel\@lists.infradead.org>\n",
- "Cc: Eric Miao <eric.y.miao\@gmail.com>\n",
- "Cc: Haojian Zhuang <haojian.zhuang\@gmail.com>\n",
- "Cc: Russell King <linux\@arm.linux.org.uk>\n",
- "---\n",
- " arch/arm/mach-mmp/pm-mmp2.c | 16 +---------------\n",
- " arch/arm/mach-mmp/pm-pxa910.c | 20 ++++----------------\n",
- " 2 files changed, 5 insertions(+), 31 deletions(-)\n",
- "\n",
- "Index: tip/arch/arm/mach-mmp/pm-mmp2.c\n",
- "===================================================================\n",
- "--- tip.orig/arch/arm/mach-mmp/pm-mmp2.c\n",
- "+++ tip/arch/arm/mach-mmp/pm-mmp2.c\n",
- "\@\@ -27,22 +27,8 \@\@\n",
- " \n",
- " int mmp2_set_wake(struct irq_data *d, unsigned int on)\n",
- " {\n",
- "-\tint irq = d->irq;\n",
- "-\tstruct irq_desc *desc = irq_to_desc(irq);\n",
- " \tunsigned long data = 0;\n",
- "-\n",
- "-\tif (unlikely(irq >= nr_irqs)) {\n",
- "-\t\tpr_err(\"IRQ nubmers are out of boundary!\\n\");\n",
- "-\t\treturn -EINVAL;\n",
- "-\t}\n",
- "-\n",
- "-\tif (on) {\n",
- "-\t\tif (desc->action)\n",
- "-\t\t\tdesc->action->flags |= IRQF_NO_SUSPEND;\n",
- "-\t} else {\n",
- "-\t\tif (desc->action)\n",
- "-\t\t\tdesc->action->flags &= ~IRQF_NO_SUSPEND;\n",
- "-\t}\n",
- "+\tint irq = d->irq;\n",
- " \n",
- " \t/* enable wakeup sources */\n",
- " \tswitch (irq) {\n",
- "Index: tip/arch/arm/mach-mmp/pm-pxa910.c\n",
- "===================================================================\n",
- "--- tip.orig/arch/arm/mach-mmp/pm-pxa910.c\n",
- "+++ tip/arch/arm/mach-mmp/pm-pxa910.c\n",
- "\@\@ -27,22 +27,8 \@\@\n",
- " \n",
- " int pxa910_set_wake(struct irq_data *data, unsigned int on)\n",
- " {\n",
- "-\tint irq = data->irq;\n",
- "-\tstruct irq_desc *desc = irq_to_desc(data->irq);\n",
- " \tuint32_t awucrm = 0, apcr = 0;\n",
- "-\n",
- "-\tif (unlikely(irq >= nr_irqs)) {\n",
- "-\t\tpr_err(\"IRQ nubmers are out of boundary!\\n\");\n",
- "-\t\treturn -EINVAL;\n",
- "-\t}\n",
- "-\n",
- "-\tif (on) {\n",
- "-\t\tif (desc->action)\n",
- "-\t\t\tdesc->action->flags |= IRQF_NO_SUSPEND;\n",
- "-\t} else {\n",
- "-\t\tif (desc->action)\n",
- "-\t\t\tdesc->action->flags &= ~IRQF_NO_SUSPEND;\n",
- "-\t}\n",
- "+\tint irq = data->irq;\n",
- " \n",
- " \t/* setting wakeup sources */\n",
- " \tswitch (irq) {\n",
- "\@\@ -115,9 +101,11 \@\@ int pxa910_set_wake(struct irq_data *dat\n",
- " \t\tif (irq >= IRQ_GPIO_START && irq < IRQ_BOARD_START) {\n",
- " \t\t\tawucrm = MPMU_AWUCRM_WAKEUP(2);\n",
- " \t\t\tapcr |= MPMU_APCR_SLPWP2;\n",
- "-\t\t} else\n",
- "+\t\t} else {\n",
- "+\t\t\t/* FIXME: This should return a proper error code ! */\n",
- " \t\t\tprintk(KERN_ERR \"Error: no defined wake up source irq: %d\\n\",\n",
- " \t\t\t\tirq);\n",
- "+\t\t}\n",
- " \t}\n",
- " \n",
- " \tif (on) {"
+ "An embedded and charset-unspecified text was scrubbed...\n",
+ "Name: arm-mmp-remove-idiotic-fiddling-with-irq-internals.patch\n",
+ "URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140223/ef9b3db6/attachment.ksh>"
]
-1d32df0e78a5df2b8ba9b86bb775d1e8e98ef1716311ad8cb91416211a38cac8
+d0fa96ee97029535a3b6d45ca3d1dc6d26bd80b12f027474f9265ae325290667
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.