From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753236AbaBYPRE (ORCPT ); Tue, 25 Feb 2014 10:17:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58011 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752572AbaBYPRC (ORCPT ); Tue, 25 Feb 2014 10:17:02 -0500 Date: Tue, 25 Feb 2014 07:19:55 -0800 From: Greg Kroah-Hartman To: Tejun Heo Cc: Li Zefan , LKML , Cgroups Subject: Re: [PATCH v3] sysfs: fix namespace refcnt leak Message-ID: <20140225151955.GA8322@kroah.com> References: <530C7E6C.2020500@huawei.com> <20140225144256.GB26788@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140225144256.GB26788@htj.dyndns.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2014 at 09:42:56AM -0500, Tejun Heo wrote: > On Tue, Feb 25, 2014 at 07:28:44PM +0800, Li Zefan wrote: > > As mount() and kill_sb() is not a one-to-one match, we shoudn't get > > ns refcnt unconditionally in sysfs_mount(), and instead we should > > get the refcnt only when kernfs_mount() allocated a new superblock. > > > > v2: > > - Changed the name of the new argument, suggested by Tejun. > > - Made the argument optional, suggested by Tejun. > > > > v3: > > - Make the new argument as second-to-last arg, suggested by Tejun. > > > > Reviewed-by: Tejun Heo > > Signed-off-by: Li Zefan > > Acked-by: Tejun Heo Is this needed for 3.14-final or 3.15? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v3] sysfs: fix namespace refcnt leak Date: Tue, 25 Feb 2014 07:19:55 -0800 Message-ID: <20140225151955.GA8322@kroah.com> References: <530C7E6C.2020500@huawei.com> <20140225144256.GB26788@htj.dyndns.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20140225144256.GB26788-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: Li Zefan , LKML , Cgroups On Tue, Feb 25, 2014 at 09:42:56AM -0500, Tejun Heo wrote: > On Tue, Feb 25, 2014 at 07:28:44PM +0800, Li Zefan wrote: > > As mount() and kill_sb() is not a one-to-one match, we shoudn't get > > ns refcnt unconditionally in sysfs_mount(), and instead we should > > get the refcnt only when kernfs_mount() allocated a new superblock. > > > > v2: > > - Changed the name of the new argument, suggested by Tejun. > > - Made the argument optional, suggested by Tejun. > > > > v3: > > - Make the new argument as second-to-last arg, suggested by Tejun. > > > > Reviewed-by: Tejun Heo > > Signed-off-by: Li Zefan > > Acked-by: Tejun Heo Is this needed for 3.14-final or 3.15? thanks, greg k-h