From: Felipe Balbi <balbi@ti.com>
To: Peter Chen <Peter.Chen@freescale.com>
Cc: Neil Zhang <zhangwm@marvell.com>, "balbi@ti.com" <balbi@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0
Date: Tue, 25 Feb 2014 12:12:34 -0600 [thread overview]
Message-ID: <20140225181234.GF23275@saruman.home> (raw)
In-Reply-To: <bce87beb86d34377ac3dae0645622edf@BN1PR03MB235.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
Hi,
On Tue, Feb 25, 2014 at 07:46:08AM +0000, Peter Chen wrote:
> > > > > > Hardware zlt will try to send the zero length packet
> > > > > > automatically when the data transferd is multiple times of max
> > > > > > packet, this will cause issues on Windows.
> > > > > > So let's disable HW zlt by default.
> > > > >
> > > > > Would you have description that what kinds of issue on Windows if
> > > > > zlt is is selected?
> > > > >
> > > >
> > > > Enumeration will fail.
> > > >
> > >
> > > What causes enumeration fail, why it does not occur before?
> > >
> > A unexpected zero packet cause enumeration fail.
> > It's not easy that the descriptor is actually 1024 bytes, so not easy to
> > be found.
> >
>
> Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data Stage, USB 2.0 spec?
wait, this is a chipidea core ? Why aren't you guys using the chipidea
driver yet ? You need to switch over to that driver dude, we can't have
duplicated code in the tree.
I'm sorry, but I won't be taking this series, please use chipidea
driver, it should be very simple to add a glue layer for your core to
the chipidea driver.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-02-25 18:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 8:03 [PATCH 0/6] bug fix for mv_udc_core.c Neil Zhang
2014-02-24 8:03 ` [PATCH 1/6] usb: gadget: mv_udc: remove redundant pull up in udc_start Neil Zhang
2014-02-24 8:03 ` [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0 Neil Zhang
2014-02-25 1:18 ` Peter Chen
2014-02-25 4:13 ` Neil Zhang
2014-02-25 5:15 ` Peter Chen
2014-02-25 7:11 ` Neil Zhang
2014-02-25 7:46 ` Peter Chen
2014-02-25 18:12 ` Felipe Balbi [this message]
2014-02-26 1:48 ` Neil Zhang
2014-02-26 2:36 ` Peter Chen
2014-02-26 15:20 ` Felipe Balbi
2014-02-26 15:23 ` Felipe Balbi
2014-02-27 3:30 ` Peter Chen
2014-02-27 16:52 ` Felipe Balbi
2014-02-27 18:05 ` Fabio Estevam
2014-02-27 19:04 ` Felipe Balbi
2014-02-26 15:19 ` Felipe Balbi
2014-02-27 9:12 ` Neil Zhang
2014-02-24 8:03 ` [PATCH 3/6] usb: gadget: mv_udc: clear corresponding interrupt when flush fifo Neil Zhang
2014-02-25 1:59 ` Peter Chen
2014-02-25 7:26 ` Neil Zhang
2014-02-24 8:03 ` [PATCH 4/6] usb: gadget: mv_udc: check endpoint before queue dtd Neil Zhang
2014-02-24 8:03 ` [PATCH 5/6] USB: gadget: mv_udc: workaroud for missing dTD Neil Zhang
2014-02-25 4:19 ` Peter Chen
2014-02-25 7:16 ` Neil Zhang
2014-02-25 7:22 ` Peter Chen
2014-02-24 8:03 ` [PATCH 6/6] USB: gadget: mv_udc: fix corner case for missiong dTD Neil Zhang
2014-02-24 10:31 ` [PATCH 0/6] bug fix for mv_udc_core.c Matthieu CASTET
2014-02-24 12:42 ` Neil Zhang
2014-02-25 4:17 ` Peter Chen
2014-02-25 7:18 ` Neil Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225181234.GF23275@saruman.home \
--to=balbi@ti.com \
--cc=Peter.Chen@freescale.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zhangwm@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.