From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 769C07F50 for ; Tue, 25 Feb 2014 14:03:36 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 3CACC304071 for ; Tue, 25 Feb 2014 12:03:33 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by cuda.sgi.com with ESMTP id 4EQ3ijb0erGPH3KY (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Tue, 25 Feb 2014 12:03:32 -0800 (PST) Date: Tue, 25 Feb 2014 12:03:32 -0800 From: Christoph Hellwig Subject: Re: [PATCH 06/10] repair: use a listhead for the dotdot list Message-ID: <20140225200332.GB22351@infradead.org> References: <1393223369-4696-1-git-send-email-david@fromorbit.com> <1393223369-4696-7-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1393223369-4696-7-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, Feb 24, 2014 at 05:29:25PM +1100, Dave Chinner wrote: > From: Dave Chinner > > Cleanup suggested by Christoph Hellwig - removes another open coded > list implementation. Looks good. Question for both the old and new code: any good reason to do the dotdot updates LIFO? If yes it might be worth adding a comment about that fact. Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs