From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57552)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WIRNh-0006rc-Ab
	for qemu-devel@nongnu.org; Tue, 25 Feb 2014 18:25:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WIRNa-0000Ym-RB
	for qemu-devel@nongnu.org; Tue, 25 Feb 2014 18:25:45 -0500
Received: from mail-qc0-x22e.google.com ([2607:f8b0:400d:c01::22e]:63930)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WIRNa-0000YZ-B8
	for qemu-devel@nongnu.org; Tue, 25 Feb 2014 18:25:38 -0500
Received: by mail-qc0-f174.google.com with SMTP id e16so200389qcx.5
	for <qemu-devel@nongnu.org>; Tue, 25 Feb 2014 15:25:37 -0800 (PST)
Date: Wed, 26 Feb 2014 09:24:59 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20140225232459.GC13907@xsjedgari30.xlnx.xilinx.com>
References: <cover.1392247170.git.peter.crosthwaite@xilinx.com>
	<CAEgOgz4xK1EioEAee6g31DPQYZ1_gx+01McR+qP=jt_nfg5w4g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEgOgz4xK1EioEAee6g31DPQYZ1_gx+01McR+qP=jt_nfg5w4g@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove
	include/hw/xilinx.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On Tue, Feb 25, 2014 at 06:46:32PM +1000, Peter Crosthwaite wrote:
> Ping!
> 

Hi Peter,

Can you please repost path nr 3, it never reached me. I'll give it
a testrun and apply.

Thanks,
Edgar


> On Thu, Feb 13, 2014 at 9:21 AM, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
> > Hi Edgar,
> >
> > This file is written for a very old qdev style of machine description.
> > Remove by inlining all usages of its functions (which is consistent with
> > the modern preference that qdev_initery should be inline and not in
> > cross-board helper functions).
> >
> > To avoid movement of magic numbers, Define macros for IRQ and memory
> > maps as appropriate. This cleanup comes first, followed by the
> > piecewise removal of xilinx.h.
> >
> > Regards,
> > Peter
> >
> >
> > Peter Crosthwaite (8):
> >   microblaze/s3adsp_1800: Define macros for irq map
> >   ppc/virtex_ml507: Define macros for irq/memory maps
> >   microblaze/ml605: Define macros for irq/memory maps
> >   xilinx: Inline usages of xilinx_intc_create()
> >   xilinx: Inline usages of xilinx_timer_create()
> >   xilinx: Inline usage of xilinx_ethlite_create()
> >   xilinx: Inline usages of xilinx_axi*_init()
> >   xilinx: Delete hw/include/xilinx.h
> >
> >  hw/microblaze/petalogix_ml605_mmu.c      | 55 ++++++++++++++-----
> >  hw/microblaze/petalogix_s3adsp1800_mmu.c | 35 ++++++++++---
> >  hw/ppc/virtex_ml507.c                    | 29 +++++++---
> >  include/hw/xilinx.h                      | 90 --------------------------------
> >  4 files changed, 95 insertions(+), 114 deletions(-)
> >  delete mode 100644 include/hw/xilinx.h
> >
> > --
> > 1.8.5.4
> >