From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 4/6] s390x: Add I/O adapter registration. Date: Wed, 26 Feb 2014 09:37:05 +0100 Message-ID: <20140226093705.3d111f2f.cornelia.huck@de.ibm.com> References: <1393349120-18228-1-git-send-email-cornelia.huck@de.ibm.com> <1393349120-18228-5-git-send-email-cornelia.huck@de.ibm.com> <530DA5D8.6040909@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <530DA5D8.6040909@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Christian Borntraeger Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, qemu-devel@nongnu.org, agraf@suse.de, pbonzini@redhat.com, gleb@kernel.org List-ID: On Wed, 26 Feb 2014 09:29:12 +0100 Christian Borntraeger wrote: > On 25/02/14 18:25, Cornelia Huck wrote: > > > +int kvm_s390_io_adapter_map(uint32_t id, uint64_t map_addr, bool do_map) > > +{ > > + struct kvm_s390_io_adapter_req req = { > > + .id = id, > > + .type = do_map ? KVM_S390_IO_ADAPTER_MAP : KVM_S390_IO_ADAPTER_UNMAP, > > + .addr = map_addr, > > + }; > > + KVMS390FLICState *flic = s390_get_flic(); > > + struct kvm_device_attr attr; > > Can we use designated initializer for attr, e.g. > struct kvm_device_attr attr = { > .group = KVM_DEV_FLIC_ADAPTER_MODIFY, > .addr = (uint64_t)&req, > } > > > + int r; > > + > > + if (!flic) { > > + return -ENOSYS; > > + } > > + if (!kvm_check_extension(kvm_state, KVM_CAP_IRQ_ROUTING)) { > > + return -ENOSYS; > > + } > > + > > + attr.group = KVM_DEV_FLIC_ADAPTER_MODIFY; > > + attr.addr = (uint64_t)&req; > > and not do it here. That will zero out the other fields of attr. > > Same for the register code. > Hm, yes, I missed that. I'll change it for the next version. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIZzX-0003i0-Gt for qemu-devel@nongnu.org; Wed, 26 Feb 2014 03:37:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIZzO-0007g8-Ia for qemu-devel@nongnu.org; Wed, 26 Feb 2014 03:37:23 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:37128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIZzO-0007dz-8R for qemu-devel@nongnu.org; Wed, 26 Feb 2014 03:37:14 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Feb 2014 08:37:11 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 42FCA1B08072 for ; Wed, 26 Feb 2014 08:36:50 +0000 (GMT) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s1Q8avST59375860 for ; Wed, 26 Feb 2014 08:36:57 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s1Q8b89T023000 for ; Wed, 26 Feb 2014 01:37:08 -0700 Date: Wed, 26 Feb 2014 09:37:05 +0100 From: Cornelia Huck Message-ID: <20140226093705.3d111f2f.cornelia.huck@de.ibm.com> In-Reply-To: <530DA5D8.6040909@de.ibm.com> References: <1393349120-18228-1-git-send-email-cornelia.huck@de.ibm.com> <1393349120-18228-5-git-send-email-cornelia.huck@de.ibm.com> <530DA5D8.6040909@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] s390x: Add I/O adapter registration. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, gleb@kernel.org, qemu-devel@nongnu.org, agraf@suse.de, pbonzini@redhat.com On Wed, 26 Feb 2014 09:29:12 +0100 Christian Borntraeger wrote: > On 25/02/14 18:25, Cornelia Huck wrote: > > > +int kvm_s390_io_adapter_map(uint32_t id, uint64_t map_addr, bool do_map) > > +{ > > + struct kvm_s390_io_adapter_req req = { > > + .id = id, > > + .type = do_map ? KVM_S390_IO_ADAPTER_MAP : KVM_S390_IO_ADAPTER_UNMAP, > > + .addr = map_addr, > > + }; > > + KVMS390FLICState *flic = s390_get_flic(); > > + struct kvm_device_attr attr; > > Can we use designated initializer for attr, e.g. > struct kvm_device_attr attr = { > .group = KVM_DEV_FLIC_ADAPTER_MODIFY, > .addr = (uint64_t)&req, > } > > > + int r; > > + > > + if (!flic) { > > + return -ENOSYS; > > + } > > + if (!kvm_check_extension(kvm_state, KVM_CAP_IRQ_ROUTING)) { > > + return -ENOSYS; > > + } > > + > > + attr.group = KVM_DEV_FLIC_ADAPTER_MODIFY; > > + attr.addr = (uint64_t)&req; > > and not do it here. That will zero out the other fields of attr. > > Same for the register code. > Hm, yes, I missed that. I'll change it for the next version.