All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/8] arm64: Do not double -mstrict-align option
Date: Wed, 26 Feb 2014 23:08:18 +0100	[thread overview]
Message-ID: <20140226230818.7c67db8a@lilith> (raw)
In-Reply-To: <20140226220308.GF16805@bill-the-cat>

Hi Tom,

On Wed, 26 Feb 2014 17:03:08 -0500, Tom Rini <trini@ti.com> wrote:

> On Wed, Feb 26, 2014 at 10:58:10PM +0100, Albert ARIBAUD wrote:
> > Hi Tom,
> > 
> > On Wed, 26 Feb 2014 08:55:43 -0500, Tom Rini <trini@ti.com> wrote:
> > 
> > > On Wed, Feb 26, 2014 at 02:51:05PM +0900, Masahiro Yamada wrote:
> > > 
> > > > Seeing arch/arm/cpu/armv8/config.mk, -mstrict-align option
> > > > was added to both PLATFORM_NO_UNALIGNED and PLATFORM_CPPFLAGS.
> > > > 
> > > > $(PLATFORM_CPPFLAGS) is given to all compiled objects.
> > > > Adding the same option to also PLATFORM_NO_UNALIGNED is
> > > > redundant.
> > > > 
> > > > For example, common/hush.o was compiled with double -mstrict-align.
> > > > You can comfirm it by checking common/.hush.o.cmd file.
> > > > 
> > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > > Cc: David Feng <fenghua@phytium.com.cn>
> > > > Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > > > Cc: Tom Rini <trini@ti.com>
> > > 
> > > With the v3 series about unaligned bits this patch should no longer be
> > > needed.
> > 
> > Hmm... This patch is about not repeating -mstrict-align twice, which is
> > a bug unrelated with switching to -mno-unaligned-access.
> > 
> > Besides, -mstrict-align means "Don't assume that unaligned accesses are
> > handled", which I think is for aarch64 what -mno-unaligned-access is
> > for arm(32), so it *should* be specified.
> 
> Yes, but my patch cleaned up the places that set PLATFORM_NO_UNALIGNED
> so this duplication was dropped.

Oh, ok. My bad, then.

Amicalement,
-- 
Albert.

  reply	other threads:[~2014-02-26 22:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26  5:50 [U-Boot] [PATCH 0/8] Kbuild: A collection of trivial refactoring Masahiro Yamada
2014-02-26  5:50 ` [U-Boot] [PATCH 1/8] config.mk: Delete unused variable BCURDIR Masahiro Yamada
2014-03-04 19:15   ` [U-Boot] [U-Boot, " Tom Rini
2014-02-26  5:50 ` [U-Boot] [PATCH 2/8] Makefile: delete unused variable LDSCRIPT_MAKEFILE_DIR Masahiro Yamada
2014-03-04 19:15   ` [U-Boot] [U-Boot, " Tom Rini
2014-02-26  5:51 ` [U-Boot] [PATCH 3/8] nand_spl: simpc8313: move config.mk used only for nand_spl Masahiro Yamada
2014-03-04 19:15   ` [U-Boot] [U-Boot, " Tom Rini
2014-02-26  5:51 ` [U-Boot] [PATCH 4/8] x86: Delete redundant compiler flags Masahiro Yamada
2014-02-27 20:44   ` Simon Glass
2014-03-04 19:15   ` [U-Boot] [U-Boot,4/8] " Tom Rini
2014-02-26  5:51 ` [U-Boot] [PATCH 5/8] sh: Do not define -ffreestanding twice Masahiro Yamada
2014-02-27 21:24   ` Nobuhiro Iwamatsu
2014-02-28  3:39     ` Masahiro Yamada
2014-03-04 20:37       ` Tom Rini
2014-03-05  0:45         ` Nobuhiro Iwamatsu
2014-03-05  2:10           ` Tom Rini
2014-02-26  5:51 ` [U-Boot] [PATCH 6/8] sh: merge compiler flag -ffixed-r13 Masahiro Yamada
2014-02-27 21:24   ` Nobuhiro Iwamatsu
2014-02-26  5:51 ` [U-Boot] [PATCH 7/8] m68k: merge compile flags -ffixed-d7 -sep-data Masahiro Yamada
2014-03-04 19:16   ` [U-Boot] [U-Boot, " Tom Rini
2014-02-26  5:51 ` [U-Boot] [PATCH 8/8] arm64: Do not double -mstrict-align option Masahiro Yamada
2014-02-26 13:55   ` Tom Rini
2014-02-26 21:58     ` Albert ARIBAUD
2014-02-26 22:03       ` Tom Rini
2014-02-26 22:08         ` Albert ARIBAUD [this message]
2014-02-26 13:56 ` [U-Boot] [PATCH 0/8] Kbuild: A collection of trivial refactoring Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226230818.7c67db8a@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.