From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] mkfs: proto file creation does not set ftype correctly
Date: Fri, 28 Feb 2014 06:40:37 +1100 [thread overview]
Message-ID: <20140227194037.GC30131@dastard> (raw)
In-Reply-To: <530F4907.5010808@sandeen.net>
On Thu, Feb 27, 2014 at 08:17:43AM -0600, Eric Sandeen wrote:
> On 2/27/14, 3:45 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Hence running xfs_repair on a ftype enable filesystem that has
> > contents created by a proto file will throw warnings on mismatched
> > ftype entries and correct them. xfs/031 fails due to this problem.
> >
> > Fix it by settin gup the xname structure with the correct type
>
> "setting up"
>
> > fields.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> huh, surprised that hung out there for so long ;)
Just shows how long it took my backlog down far enough to deal with
non-critical xfstests failures on CRC enabled filesystems...
> I guess the root inode is handled by core mkfs code, right?
> (around line 544)
Yes - and the root inode is indexed in a directory (it's indexed by
the superblock), so there's not ftype entry to be set up.
> And I notice that "r" filetypes aren't documented in the
> manpage but that's a different issue.
Patch? ;)
> As long as I'm right about the root inode,
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-27 19:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 9:45 [PATCH 0/2] xfsprogs: mkfs fixes Dave Chinner
2014-02-27 9:45 ` [PATCH 1/2] mkfs: default log size for small filesystems too large Dave Chinner
2014-02-27 22:29 ` Eric Sandeen
2014-02-28 1:03 ` Dave Chinner
2014-02-28 3:12 ` Eric Sandeen
2014-02-28 13:09 ` Brian Foster
2014-02-27 9:45 ` [PATCH 2/2] mkfs: proto file creation does not set ftype correctly Dave Chinner
2014-02-27 14:17 ` Eric Sandeen
2014-02-27 19:40 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227194037.GC30131@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.