From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Wilson Subject: Re: Support for btrfs in pv-grub Date: Thu, 27 Feb 2014 19:30:31 -0800 Message-ID: <20140228033029.GA14114@u109add4315675089e695.ant.amazon.com> References: <530E0F7E02000091000B8C20@prv-mh.provo.novell.com> <1393555348.20365.11.camel@hastur.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1393555348.20365.11.camel@hastur.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Charles Arnold , Matt Wilson , xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, Feb 28, 2014 at 02:42:28AM +0000, Ian Campbell wrote: > On Wed, 2014-02-26 at 15:59 -0700, Charles Arnold wrote: > > Code to support btrfs in pv-grub was added almost two years ago (c/s 25154). > > Ccing the author. > > > Building the code doesn't seem to be enabled in stubdom/grub/Makefile. > > Was this functionality ever intended to work? > > One would like to assume so! > > > Does anyone know the status of this code? > > Matt? > > Looks like Makefile.am was patched but not Makefile.in, and I don't > think we run automake as part of the stubdom build process. True, but we also don't use the Makefiles in grub-upstream to build GRUB. We use xen/stubdom/grub/Makefile, which also isn't patched to build the btrfs code. Unfortunately when I added it grub/Makefile, it doesn't build on a modern compiler. Do you think we should revert the patch that adds btrfs support? --msw