From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Subject: Re: [PATCH 02/11] devices-args: introduce rte_devargs in
 eal
Date: Fri, 28 Feb 2014 13:39:29 -0800
Message-ID: <20140228133929.03844b24@nehalam.linuxnetplumber.net>
References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com>
 <1393608350-4431-3-git-send-email-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1393608350-4431-3-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Fri, 28 Feb 2014 18:25:41 +0100
Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:

> 	switch (devargs->type) {
> +		case RTE_DEVTYPE_WHITELISTED_PCI:
> +		case RTE_DEVTYPE_BLACKLISTED_PCI:
> +			/* try to parse pci identifier */
> +			if (eal_parse_pci_BDF(buf, &devargs->pci.addr) != 0 &&
> +				eal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0) {
> +				RTE_LOG(ERR, EAL,
> +					"invalid PCI identifier <%s>\n", buf);
> +				free(devargs);
> +				return -1;
> +			}
> +			break;

Minor nit. please align case with switch().
The DPDK in general follows Linux coding style.
In fact, I have run the code through checkpatch to find style issues.