From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752954AbaB1QQh (ORCPT ); Fri, 28 Feb 2014 11:16:37 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:53960 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbaB1QQf (ORCPT ); Fri, 28 Feb 2014 11:16:35 -0500 Date: Fri, 28 Feb 2014 16:15:59 +0000 From: Will Deacon To: AKASHI Takahiro Cc: "viro@zeniv.linux.org.uk" , "eparis@redhat.com" , "rgb@redhat.com" , Catalin Marinas , "dsaxena@linaro.org" , "arndb@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" , "linux-audit@redhat.com" Subject: Re: [PATCH v6 2/2] arm64: audit: Add audit hook in ptrace/syscall_trace Message-ID: <20140228161558.GE29546@mudshark.cambridge.arm.com> References: <1393319934-2810-1-git-send-email-takahiro.akashi@linaro.org> <1393564635-3921-1-git-send-email-takahiro.akashi@linaro.org> <1393564635-3921-3-git-send-email-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1393564635-3921-3-git-send-email-takahiro.akashi@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 28, 2014 at 05:17:15AM +0000, AKASHI Takahiro wrote: > This patch adds auditing functions on entry to or exit from > every system call invocation. > > Acked-by: Richard Guy Briggs > Signed-off-by: AKASHI Takahiro > --- > arch/arm64/kernel/ptrace.c | 54 ++++++++++++++++++++++++++------------------ > 1 file changed, 32 insertions(+), 22 deletions(-) I think you need to do something like I did for arch/arm/, where we have separate trace functions for entry/exit to make sure that we invoke the various helpers in the correct order (for example, you want to invoke all the debug stuff *first* on entry, but *last* on exit). Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v6 2/2] arm64: audit: Add audit hook in ptrace/syscall_trace Date: Fri, 28 Feb 2014 16:15:59 +0000 Message-ID: <20140228161558.GE29546@mudshark.cambridge.arm.com> References: <1393319934-2810-1-git-send-email-takahiro.akashi@linaro.org> <1393564635-3921-1-git-send-email-takahiro.akashi@linaro.org> <1393564635-3921-3-git-send-email-takahiro.akashi@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1393564635-3921-3-git-send-email-takahiro.akashi@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: AKASHI Takahiro Cc: "linaro-kernel@lists.linaro.org" , "rgb@redhat.com" , Catalin Marinas , "arndb@arndb.de" , "eparis@redhat.com" , "linux-kernel@vger.kernel.org" , "dsaxena@linaro.org" , "viro@zeniv.linux.org.uk" , "linux-audit@redhat.com" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-audit@redhat.com On Fri, Feb 28, 2014 at 05:17:15AM +0000, AKASHI Takahiro wrote: > This patch adds auditing functions on entry to or exit from > every system call invocation. > > Acked-by: Richard Guy Briggs > Signed-off-by: AKASHI Takahiro > --- > arch/arm64/kernel/ptrace.c | 54 ++++++++++++++++++++++++++------------------ > 1 file changed, 32 insertions(+), 22 deletions(-) I think you need to do something like I did for arch/arm/, where we have separate trace functions for entry/exit to make sure that we invoke the various helpers in the correct order (for example, you want to invoke all the debug stuff *first* on entry, but *last* on exit). Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Fri, 28 Feb 2014 16:15:59 +0000 Subject: [PATCH v6 2/2] arm64: audit: Add audit hook in ptrace/syscall_trace In-Reply-To: <1393564635-3921-3-git-send-email-takahiro.akashi@linaro.org> References: <1393319934-2810-1-git-send-email-takahiro.akashi@linaro.org> <1393564635-3921-1-git-send-email-takahiro.akashi@linaro.org> <1393564635-3921-3-git-send-email-takahiro.akashi@linaro.org> Message-ID: <20140228161558.GE29546@mudshark.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 28, 2014 at 05:17:15AM +0000, AKASHI Takahiro wrote: > This patch adds auditing functions on entry to or exit from > every system call invocation. > > Acked-by: Richard Guy Briggs > Signed-off-by: AKASHI Takahiro > --- > arch/arm64/kernel/ptrace.c | 54 ++++++++++++++++++++++++++------------------ > 1 file changed, 32 insertions(+), 22 deletions(-) I think you need to do something like I did for arch/arm/, where we have separate trace functions for entry/exit to make sure that we invoke the various helpers in the correct order (for example, you want to invoke all the debug stuff *first* on entry, but *last* on exit). Will