All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@debian.org>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer
Date: Sat, 1 Mar 2014 00:22:23 +0100	[thread overview]
Message-ID: <20140228232223.GB23878@earth.universe> (raw)
In-Reply-To: <CAAfyv36RPCkUKLOC6yHRwaNjA16EeG_niyfZoaJ15LZ5_HdR7g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

Hi Marek,

On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote:
> Seems I found issue. I have missing property ti,system-uses-second-madc-irq
> as original twl4030_madc_battery used SW2 but this change doesn't fix completely
> the problem.

I remember adding this property because you requested it :) Good to
know, that its really needed.

> What it fixed completely is change:
> -       req.raw = !(mask == IIO_CHAN_INFO_PROCESSED);
> +       req.raw = 0;//!(mask == IIO_CHAN_INFO_PROCESSED);

ok, that figures it. Instead of changing the twl4030-madc driver
you should change the twl4030-madc-battery driver. You currently
call iio_read_channel_raw(), which gives you raw values. Your
driver wants processed data from twl4030-madc, so you should use
iio_read_channel_processed() instead.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-02-28 23:22 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26  0:46 [PATCHv1 0/2] Convert rx51-battery to IIO API and add DT support Sebastian Reichel
2014-02-26  0:46 ` Sebastian Reichel
2014-02-26  0:46 ` [PATCHv1 1/2] rx51_battery: convert to iio consumer Sebastian Reichel
2014-02-26 21:43   ` Belisko Marek
2014-02-26 21:43     ` Belisko Marek
2014-02-26 21:54     ` Sebastian Reichel
2014-02-26 21:54       ` Sebastian Reichel
2014-02-27 21:34       ` Belisko Marek
2014-02-28  2:05         ` Sebastian Reichel
2014-02-28 20:32           ` Belisko Marek
2014-02-28 20:59             ` Belisko Marek
2014-02-28 20:59               ` Belisko Marek
2014-02-28 21:08             ` Sebastian Reichel
2014-02-28 21:13               ` Belisko Marek
2014-02-28 22:32                 ` Belisko Marek
2014-02-28 23:22                   ` Sebastian Reichel [this message]
2014-03-04 21:20                     ` Belisko Marek
2014-03-04 22:02                       ` Sebastian Reichel
2014-03-01 11:17   ` Jonathan Cameron
2014-03-01 11:17     ` Jonathan Cameron
2014-03-01 11:22     ` Jonathan Cameron
2014-03-01 11:22       ` Jonathan Cameron
2014-02-26  0:46 ` [PATCHv1 2/2] Documentation: DT: Document rx51-battery binding Sebastian Reichel
2014-02-26  0:46   ` Sebastian Reichel
2014-02-26  7:40 ` [PATCHv1 0/2] Convert rx51-battery to IIO API and add DT support Pali Rohár
2014-02-26  7:40   ` Pali Rohár
2014-02-26  7:40   ` Pali Rohár
2014-02-26 17:51   ` Sebastian Reichel
2014-02-26 17:51     ` Sebastian Reichel
2014-03-01 20:22 ` [PATCHv2 " Sebastian Reichel
2014-03-01 20:22   ` Sebastian Reichel
2014-03-01 20:22   ` [PATCHv2 1/2] rx51_battery: convert to iio consumer Sebastian Reichel
2014-03-29 11:09     ` Jonathan Cameron
2014-03-29 11:09       ` Jonathan Cameron
2014-04-20 12:08       ` Pavel Machek
2014-04-23 16:09         ` Sebastian Reichel
2014-04-23 16:09           ` Sebastian Reichel
2014-06-14  8:32           ` Pavel Machek
2014-06-14  8:32             ` Pavel Machek
2014-06-14 15:47             ` Sebastian Reichel
2014-06-14 15:47               ` Sebastian Reichel
2014-03-01 20:22   ` [PATCHv2 2/2] Documentation: DT: Document rx51-battery binding Sebastian Reichel
2014-03-01 20:22     ` Sebastian Reichel
2014-03-29 11:10     ` Jonathan Cameron
2014-03-29 11:10       ` Jonathan Cameron
2014-04-20 12:09     ` Pavel Machek
2014-04-20 12:09       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140228232223.GB23878@earth.universe \
    --to=sre@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.