All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Do not accept name attributes which include '-'
Date: Sun, 02 Mar 2014 13:54:20 +0000	[thread overview]
Message-ID: <20140302145420.662e0bf1@endymion.delvare> (raw)
In-Reply-To: <1393612837-20042-1-git-send-email-linux@roeck-us.net>

On Sun, 2 Mar 2014 14:17:43 +0100, Jean Delvare wrote:
> Also I think we want to discuss the x86_pkg_temp_thermal driver case
> with the guys responsible for it. The driver creates a thermal zone
> with type "pkg-temp-0" (and "pkg-temp-1" etc. if you have more than one
> CPU.) The thermal-to-hwmon bridge puts "pkg-temp-0" in the name
> attribute, which causes libsensors to have to deal with a device named
> "pkg-temp-0-virtual-0". Horrible.
> 
> Changing "pkg-temp" to "pkg_temp" isn't enough. We also need to teach
> the thermal-to-hwmon bridge how to deal with multiple instances of the
> same thermal device. And we need to find a way to transmit the
> information to libsensors (presumably trough a new sysfs attribute?),
> and then implement the support in libsensors.

Correction: the thermal-to-hwmon bridge consolidates the thermal zones
of the same type into a single hwmon device. So there will never be
multiple instances of the same type, and libsensors is fine as it is.

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2014-03-02 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 18:40 [lm-sensors] [PATCH] hwmon: Do not accept name attributes which include '-' Guenter Roeck
2014-03-02 13:17 ` Jean Delvare
2014-03-02 13:54 ` Jean Delvare [this message]
2014-03-02 14:21 ` Jean Delvare
2014-03-02 16:24 ` Guenter Roeck
2014-03-02 16:29 ` Guenter Roeck
2014-03-02 20:59 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140302145420.662e0bf1@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.