From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKkaN-0000TX-Lc for qemu-devel@nongnu.org; Tue, 04 Mar 2014 03:20:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKkaD-0002ca-D2 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 03:20:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKkaD-0002cV-3Z for qemu-devel@nongnu.org; Tue, 04 Mar 2014 03:20:13 -0500 Date: Tue, 4 Mar 2014 09:19:51 +0100 From: Stefan Hajnoczi Message-ID: <20140304081951.GB25676@stefanha-thinkpad.redhat.com> References: <20140303150037.GH21055@stefanha-thinkpad.redhat.com> <20140304073131.GC23043@G08FNSTD100614.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140304073131.GC23043@G08FNSTD100614.fnst.cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v6 0/4] qemu-img: add preallocation=full List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Kevin Wolf , Stefan Hajnoczi , Fam Zheng , qemu-devel@nongnu.org, Peter Lieven On Tue, Mar 04, 2014 at 03:31:31PM +0800, Hu Tao wrote: > On Mon, Mar 03, 2014 at 04:00:37PM +0100, Stefan Hajnoczi wrote: > > On Fri, Feb 28, 2014 at 10:29:29AM +0800, Hu Tao wrote: > > > This series implements full image preallocation to create a non-sparse image > > > file at creation time, both for raw and qcow2 format. The purpose is to avoid > > > performance deterioration of the guest cause by sparse image. > > > > > > v6: > > > - add `Since 2.0' to PreallocMode > > > - apply total_size change to raw-win32.c as well > > > > > > Hu Tao (4): > > > qapi: introduce PreallocMode and a new PreallocMode full. > > > raw, qcow2: don't convert file size to sector size > > > raw-posix: Add full image preallocation option > > > qcow2: Add full image preallocation option > > > > > > block/qcow2.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++------- > > > block/raw-posix.c | 45 +++++++++++++++++++++------ > > > block/raw-win32.c | 4 +-- > > > qapi-schema.json | 14 +++++++++ > > > 4 files changed, 132 insertions(+), 22 deletions(-) > > > > Acked-by: Stefan Hajnoczi > > Stefan, Kevin, > > Is this series in time for 2.0? Yes, it was on the mailing list before soft freeze so it is a candidate for 2.0. In some cases maintainers may decide to hold back if they feel a patch series imposes a high risk of breaking things - but I think this series should be okay. Stefan