From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Always use kref tracking for contexts. Date: Wed, 5 Mar 2014 18:43:03 +0100 Message-ID: <20140305174303.GO17001@phenom.ffwll.local> References: <1393618010-24070-1-git-send-email-chris@chris-wilson.co.uk> <20140302235808.GA1791@bwidawsk.net> <20140303071919.GB2154@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 3246BFA882 for ; Wed, 5 Mar 2014 09:43:08 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c41so617808eek.22 for ; Wed, 05 Mar 2014 09:43:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140303071919.GB2154@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 03, 2014 at 07:19:19AM +0000, Chris Wilson wrote: > On Sun, Mar 02, 2014 at 03:58:09PM -0800, Ben Widawsky wrote: > > On Fri, Feb 28, 2014 at 08:06:50PM +0000, Chris Wilson wrote: > > > ctx->obj = i915_gem_object_create_stolen(dev, dev_priv->hw_context_size); > > How this working for you ^ ? > > Fine. It helps detect cases where we try to load uninitialised contexts, > but other than that I have not noticed any difference. Separate patch pls with a note that we have a higher chance of blowing up on random stuff. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch