All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Always use kref tracking for contexts.
Date: Wed, 5 Mar 2014 17:46:32 +0000	[thread overview]
Message-ID: <20140305174632.GB15072@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20140305174303.GO17001@phenom.ffwll.local>

On Wed, Mar 05, 2014 at 06:43:03PM +0100, Daniel Vetter wrote:
> On Mon, Mar 03, 2014 at 07:19:19AM +0000, Chris Wilson wrote:
> > On Sun, Mar 02, 2014 at 03:58:09PM -0800, Ben Widawsky wrote:
> > > On Fri, Feb 28, 2014 at 08:06:50PM +0000, Chris Wilson wrote:
> > > >  	ctx->obj = i915_gem_object_create_stolen(dev, dev_priv->hw_context_size);
> > > 		  How this working for you ^ ?
> > 
> > Fine. It helps detect cases where we try to load uninitialised contexts,
> > but other than that I have not noticed any difference.
> 
> Separate patch pls with a note that we have a higher chance of blowing up
> on random stuff.

It is a separate patch. It's in the contextual diff of the patch that
Ben spotted a change I have been using for ages.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

      reply	other threads:[~2014-03-05 17:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 20:06 [PATCH] drm/i915: Always use kref tracking for contexts Chris Wilson
2014-03-02 23:58 ` Ben Widawsky
2014-03-03  7:19   ` Chris Wilson
2014-03-05 17:43     ` Daniel Vetter
2014-03-05 17:46       ` Chris Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305174632.GB15072@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=ben@bwidawsk.net \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.