All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	James Bottomley <jbottomley@parallels.com>,
	linux-scsi@vger.kernel.org, Jeremy Linton <jlinton@tributary.com>,
	Kay Sievers <kay@vrfy.org>, Doug Gilbert <dgilbert@interlog.com>,
	Kai Makisara <kai.makisara@kolumbus.fi>
Subject: Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs
Date: Wed, 5 Mar 2014 11:42:55 -0800	[thread overview]
Message-ID: <20140305194255.GA5607@infradead.org> (raw)
In-Reply-To: <5316D459.6070107@suse.de>

On Wed, Mar 05, 2014 at 08:38:01AM +0100, Hannes Reinecke wrote:
> > Either way I think the call to query evpd 0 should be a separate
> > function, so even if we don't store the information it's abstracted out.
> > 
> Hmm. That would work if we were just asking for a single page; but
> when we're checking several pages (like 0x83 and 0x80) we'd need
> either to pass in a page array or querying page 0 several times.
> Neither of which is very appealing.
>
> However, specifying additional flags for the individual pages might
> work. I'll see what I can come up with.

Passing in a bitmask or flags seems useful.  Even better storing it in the
scsi_device.  Note that I expect the place that need to know the EVPD
patch to grow slowly but steadily over time.

  reply	other threads:[~2014-03-05 19:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 10:07 [PATCHv7 0/3] Display EVPD pages in sysfs Hannes Reinecke
2014-02-13 10:07 ` [PATCH 1/3] scsi_sysfs: Implement 'is_visible' callback Hannes Reinecke
2014-02-13 10:07 ` [PATCH 2/3] Add EVPD page 0x83 to sysfs Hannes Reinecke
2014-02-28 17:01   ` Christoph Hellwig
2014-03-05  7:38     ` Hannes Reinecke
2014-03-05 19:42       ` Christoph Hellwig [this message]
2014-03-06  9:01         ` Hannes Reinecke
2014-03-07 10:11           ` Christoph Hellwig
2014-03-07 10:35             ` Hannes Reinecke
2014-03-07 10:44               ` Christoph Hellwig
2014-03-07 10:39           ` James Bottomley
2014-03-07 10:51             ` Hannes Reinecke
2014-03-07 11:01               ` James Bottomley
2014-03-07 11:18                 ` Douglas Gilbert
2014-03-07 13:39                 ` Hannes Reinecke
2014-03-07 10:40           ` James Bottomley
2014-03-07 10:43             ` Christoph Hellwig
2014-03-07 10:57               ` James Bottomley
2014-02-13 10:07 ` [PATCH 3/3] Add EVPD page 0x80 " Hannes Reinecke
2014-02-13 10:27 [PATCHv7 0/3][Resend] Display EVPD pages in sysfs Hannes Reinecke
2014-02-13 10:28 ` [PATCH 2/3] Add EVPD page 0x83 to sysfs Hannes Reinecke
2014-03-02  8:34   ` Bart Van Assche
2014-03-05  7:56     ` Hannes Reinecke
2014-03-02  8:36   ` Bart Van Assche
2014-03-05  7:56     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305194255.GA5607@infradead.org \
    --to=hch@infradead.org \
    --cc=dgilbert@interlog.com \
    --cc=hare@suse.de \
    --cc=jbottomley@parallels.com \
    --cc=jlinton@tributary.com \
    --cc=kai.makisara@kolumbus.fi \
    --cc=kay@vrfy.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.