From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Cartwright Subject: Re: [PATCH v12] gpio: add a driver for the Synopsys DesignWare APB GPIO block Date: Thu, 6 Mar 2014 07:50:19 -0600 Message-ID: <20140306135019.GF18529@joshc.qualcomm.com> References: <1393369261-17469-1-git-send-email-delicious.quinoa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:51923 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbaCFNxJ (ORCPT ); Thu, 6 Mar 2014 08:53:09 -0500 Content-Disposition: inline In-Reply-To: <1393369261-17469-1-git-send-email-delicious.quinoa@gmail.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Alan Tull Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, Jamie Iles , "devicetree@vger.kernel.org" , Rob Herring , Grant Likely , Mark Rutland , Steffen Trumtrar , Sebastian Hesselbarth , Heiko Stuebner , Alan Tull , Dinh Nguyen , Yves Vandervennet On Tue, Feb 25, 2014 at 05:01:01PM -0600, Alan Tull wrote: > From: Jamie Iles > > The Synopsys DesignWare block is used in some ARM devices (picoxcell) > and can be configured to provide multiple banks of GPIO pins. > > Signed-off-by: Jamie Iles > Signed-off-by: Alan Tull > Reviewed-by: Sebastian Hesselbarth [..] > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -128,6 +128,15 @@ config GPIO_GENERIC_PLATFORM > help > Say yes here to support basic platform_device memory-mapped GPIO controllers. > > +config GPIO_DWAPB > + tristate "Synopsys DesignWare APB GPIO driver" > + select GPIO_GENERIC > + select GENERIC_IRQ_CHIP > + depends on OF_GPIO && IRQ_DOMAIN > + help > + Say Y or M here to build support for the Synopsys DesignWare APB > + GPIO block. > + Looks like this hit next-20140306, when just doing a simple 'make defconfig', I get: kernel/irq/Kconfig:41:error: recursive dependency detected! kernel/irq/Kconfig:41: symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB drivers/gpio/Kconfig:131: symbol GPIO_DWAPB depends on IRQ_DOMAIN kernel/irq/Kconfig:46: symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP Not sure the best course of action here.. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation