From: Steven Rostedt <rostedt@goodmis.org> To: Jiri Slaby <jslaby@suse.cz> Cc: jirislaby@gmail.com, linux-kernel@vger.kernel.org, Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@redhat.com> Subject: Re: [PATCH v2 6/6] ftrace: Fix compilation warning about control_ops_free Date: Thu, 6 Mar 2014 15:31:51 -0500 [thread overview] Message-ID: <20140306153151.4f7ca9ca@gandalf.local.home> (raw) In-Reply-To: <1393268401-24379-6-git-send-email-jslaby@suse.cz> On Mon, 24 Feb 2014 20:00:01 +0100 Jiri Slaby <jslaby@suse.cz> wrote: > With CONFIG_DYNAMIC_FTRACE=n, I see a warning: > kernel/trace/ftrace.c:240:13: warning: 'control_ops_free' defined but not used > static void control_ops_free(struct ftrace_ops *ops) > ^ > Add an ifdef block with CONFIG_DYNAMIC_FTRACE around that function as > it is used solely from the dynamic function tracing functions. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Ingo Molnar <mingo@redhat.com> > --- > kernel/trace/ftrace.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 5bd70e8b09b0..34b1de9390af 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -237,10 +237,12 @@ static int control_ops_alloc(struct ftrace_ops *ops) > return 0; > } > > +#ifdef CONFIG_DYNAMIC_FTRACE > static void control_ops_free(struct ftrace_ops *ops) > { > free_percpu(ops->disabled); > } > +#endif I've pulled in all your patches up to this one. But instead of adding another #ifdef CONFIG_DYNAMIC_FTRACE, please just move the function into the block that it's used in. Just resend this patch. The others are already in my 3.15 queue. Thanks, -- Steve > > static void update_global_ops(void) > {
next prev parent reply other threads:[~2014-03-06 20:31 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-24 18:59 [PATCH v2 1/6] ftrace: Cleanup of global variables Jiri Slaby 2014-02-24 18:59 ` [PATCH v2 2/6] ftrace: Inline the code from ftrace_dyn_table_alloc Jiri Slaby 2014-02-24 18:59 ` [PATCH v2 3/6] ftrace: Pass retval through return in ftrace_dyn_arch_init Jiri Slaby 2014-02-24 18:59 ` [PATCH v2 4/6] ftrace: Do not pass data to ftrace_dyn_arch_init Jiri Slaby 2014-02-24 19:00 ` [PATCH v2 5/6] ftrace: Remove freelist from struct dyn_ftrace Jiri Slaby 2014-02-24 19:00 ` [PATCH v2 6/6] ftrace: Fix compilation warning about control_ops_free Jiri Slaby 2014-03-06 20:31 ` Steven Rostedt [this message] 2014-03-10 20:42 ` Jiri Slaby
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140306153151.4f7ca9ca@gandalf.local.home \ --to=rostedt@goodmis.org \ --cc=fweisbec@gmail.com \ --cc=jirislaby@gmail.com \ --cc=jslaby@suse.cz \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --subject='Re: [PATCH v2 6/6] ftrace: Fix compilation warning about control_ops_free' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.